You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/08 03:32:55 UTC

[GitHub] [rocketmq] ShannonDing opened a new issue #3597: Make sure the list of cid and message queue is not null in AllocateMessageQueueByMachineRoom.allocate.

ShannonDing opened a new issue #3597:
URL: https://github.com/apache/rocketmq/issues/3597


   According to the other strategy, all the parameter should be checked before allocating.
   such as :
   ```
           if (currentCID == null || currentCID.length() < 1) {
               throw new IllegalArgumentException("currentCID is empty");
           }
           if (mqAll == null || mqAll.isEmpty()) {
               throw new IllegalArgumentException("mqAll is null or mqAll empty");
           }
           if (cidAll == null || cidAll.isEmpty()) {
               throw new IllegalArgumentException("cidAll is null or cidAll empty");
           }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] vongosling closed issue #3597: Make sure the list of cid and message queue is not null in AllocateMessageQueueByMachineRoom.allocate.

Posted by GitBox <gi...@apache.org>.
vongosling closed issue #3597:
URL: https://github.com/apache/rocketmq/issues/3597


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] zhaohai1299002788 edited a comment on issue #3597: Make sure the list of cid and message queue is not null in AllocateMessageQueueByMachineRoom.allocate.

Posted by GitBox <gi...@apache.org>.
zhaohai1299002788 edited a comment on issue #3597:
URL: https://github.com/apache/rocketmq/issues/3597#issuecomment-988533328


   #3656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] zhaohai1299002788 commented on issue #3597: Make sure the list of cid and message queue is not null in AllocateMessageQueueByMachineRoom.allocate.

Posted by GitBox <gi...@apache.org>.
zhaohai1299002788 commented on issue #3597:
URL: https://github.com/apache/rocketmq/issues/3597#issuecomment-988533328


   #3598


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org