You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergio Pena <se...@cloudera.com> on 2014/08/07 22:42:16 UTC
Review Request 24467: HIVE-7373: Hive should not remove trailing zeros for
decimal numbers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
data/files/kv10.txt PRE-CREATION
hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java 82fc8a9
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
ql/src/test/results/clientpositive/compute_stats_decimal.q.out 2a65efe
ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
ql/src/test/results/clientpositive/serde_regex.q.out e231a09
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out 78e340b
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 71a3def
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out 717e81a
ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing
zeros for decimal numbers
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 8:26 p.m.)
Review request for hive.
Changes
-------
Fixed decimal_trailing.q
It started failing after I did a rebase on origin/trunk
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
data/files/kv10.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 88268ce
ql/src/test/results/clientpositive/avro_decimal_native.q.out c8ae0fb
ql/src/test/results/clientpositive/char_pad_convert.q.out 26102e4
ql/src/test/results/clientpositive/decimal_2.q.out 934590c
ql/src/test/results/clientpositive/decimal_3.q.out 8e9a30a
ql/src/test/results/clientpositive/decimal_4.q.out 50662af
ql/src/test/results/clientpositive/decimal_5.q.out 0f24b8a
ql/src/test/results/clientpositive/decimal_6.q.out c0cad1f
ql/src/test/results/clientpositive/decimal_precision.q.out f3f2cbc
ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_udf.q.out 1d5fee9
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f25b442
ql/src/test/results/clientpositive/parquet_decimal.q.out cd87b92
ql/src/test/results/clientpositive/parquet_decimal1.q.out bd146f8
ql/src/test/results/clientpositive/serde_regex.q.out 65e7dec
ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 07529b8
ql/src/test/results/clientpositive/tez/vector_data_types.q.out f577e13
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out bbd23d2
ql/src/test/results/clientpositive/vector_data_types.q.out a1183ad
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 3327c90
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out d60d855
ql/src/test/results/clientpositive/windowing_decimal.q.out 08dd6ab
ql/src/test/results/clientpositive/windowing_navfn.q.out f2f2cb4
ql/src/test/results/clientpositive/windowing_rank.q.out 6a74a8e
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing
zeros for decimal numbers
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 6:01 p.m.)
Review request for hive.
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
data/files/kv10.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426
ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
ql/src/test/results/clientpositive/serde_regex.q.out e231a09
ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 9abaa46
ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out bbd23d2
ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 3327c90
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out d60d855
ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing
zeros for decimal numbers
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
(Updated Aug. 14, 2014, 7:52 p.m.)
Review request for hive.
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
data/files/kv10.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426
ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
ql/src/test/results/clientpositive/serde_regex.q.out e231a09
ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 9abaa46
ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out bbd23d2
ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 3327c90
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out d60d855
ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing
zeros for decimal numbers
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
(Updated Aug. 14, 2014, 4 p.m.)
Review request for hive.
Changes
-------
Fixed failed tests, and added Brock's comments
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_decimal
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_decimal_native
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_compute_stats_decimal
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
data/files/kv10.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426
ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
ql/src/test/results/clientpositive/serde_regex.q.out e231a09
ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 9abaa46
ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out bbd23d2
ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 3327c90
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out d60d855
ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros
for decimal numbers
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 9:42 p.m.)
Review request for hive.
Changes
-------
Fix tests failing because of the hashCode() change.
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426
ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
ql/src/test/results/clientpositive/serde_regex.q.out e231a09
ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 9abaa46
ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out bbd23d2
ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 3327c90
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out d60d855
ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros
for decimal numbers
Posted by Sergio Pena <se...@cloudera.com>.
> On Aug. 11, 2014, 9:55 p.m., Brock Noland wrote:
> > common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java, line 642
> > <https://reviews.apache.org/r/24467/diff/3/?file=657996#file657996line642>
> >
> > nit: extra line
What's wrong with the extra line?
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/#review50241
-----------------------------------------------------------
On Aug. 12, 2014, 9:42 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24467/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 9:42 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7373
> https://issues.apache.org/jira/browse/HIVE-7373
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
> This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
>
> The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
> common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
> common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
> ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
> ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
> ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
> ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
> ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426
> ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
> ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
> ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
> ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
> ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
> ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
> ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
> ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
> ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
> ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
> ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
> ql/src/test/results/clientpositive/serde_regex.q.out e231a09
> ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 9abaa46
> ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825
> ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
> ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
> ql/src/test/results/clientpositive/udf_when.q.out cbb1210
> ql/src/test/results/clientpositive/vector_between_in.q.out bbd23d2
> ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8
> ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
> ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
> ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
> ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 3327c90
> ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out d60d855
> ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
> ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
> ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
> serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
>
> Diff: https://reviews.apache.org/r/24467/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros
for decimal numbers
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/#review50241
-----------------------------------------------------------
This looks really great!! Nice work. One comment a single nit below.
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java
<https://reviews.apache.org/r/24467/#comment87894>
Can you add a comment as to why we need to do this as opposed to taking the incoming scale?
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java
<https://reviews.apache.org/r/24467/#comment87896>
nit: extra line
- Brock Noland
On Aug. 11, 2014, 9:22 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24467/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 9:22 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7373
> https://issues.apache.org/jira/browse/HIVE-7373
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
> This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
>
> The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
> common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
> common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
> data/files/kv10.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
> ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
> ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
> ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
> ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
> ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
> ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426
> ql/src/test/results/clientpositive/compute_stats_decimal.q.out 2a65efe
> ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
> ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
> ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
> ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
> ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
> ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
> ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
> ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
> ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
> ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
> ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
> ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
> ql/src/test/results/clientpositive/serde_regex.q.out e231a09
> ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 9abaa46
> ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825
> ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
> ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
> ql/src/test/results/clientpositive/udf_when.q.out cbb1210
> ql/src/test/results/clientpositive/vector_between_in.q.out 78e340b
> ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8
> ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
> ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
> ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
> ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 71a3def
> ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out 717e81a
> ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
> ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
> ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
> serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
>
> Diff: https://reviews.apache.org/r/24467/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros
for decimal numbers
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 9:22 p.m.)
Review request for hive.
Changes
-------
Trim decimal when returning its hashCode() so queries can return correct values where two decimal fields with different scale values are being compared
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
data/files/kv10.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426
ql/src/test/results/clientpositive/compute_stats_decimal.q.out 2a65efe
ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
ql/src/test/results/clientpositive/serde_regex.q.out e231a09
ql/src/test/results/clientpositive/tez/mapjoin_decimal.q.out 9abaa46
ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out 78e340b
ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 71a3def
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out 717e81a
ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 24467: HIVE-7373: Hive should not remove trailing zeros
for decimal numbers
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24467/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 3:23 a.m.)
Review request for hive.
Changes
-------
Fix additional queries tests.
Bugs: HIVE-7373
https://issues.apache.org/jira/browse/HIVE-7373
Repository: hive-git
Description
-------
Removes trim() call from HiveDecimal normalize/enforcePrecisionScale methods.
This change affects the Decimal128 getHiveDecimalString() method; so a new 'actualScale' variable is used that stores the actual scale of a value passed to Decimal128.
The rest of the changes are added to fix decimal query tests to match the new HiveDecimal value.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java d4cc32d
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java ad09015
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 46236a5
common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java 1384a45
data/files/kv10.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java f5023bb
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 2a871c5
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java b1524f7
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java 4c5b3a5
ql/src/test/queries/clientpositive/decimal_trailing.q PRE-CREATION
ql/src/test/queries/clientpositive/literal_decimal.q 08b21dc
ql/src/test/results/clientpositive/avro_decimal.q.out 1868de3
ql/src/test/results/clientpositive/avro_decimal_native.q.out bc87a7d
ql/src/test/results/clientpositive/char_pad_convert.q.out 1f81426
ql/src/test/results/clientpositive/compute_stats_decimal.q.out 2a65efe
ql/src/test/results/clientpositive/decimal_2.q.out 794bad0
ql/src/test/results/clientpositive/decimal_3.q.out 524fa62
ql/src/test/results/clientpositive/decimal_4.q.out 7444e83
ql/src/test/results/clientpositive/decimal_5.q.out 52dae22
ql/src/test/results/clientpositive/decimal_6.q.out 4338b52
ql/src/test/results/clientpositive/decimal_precision.q.out ea08b73
ql/src/test/results/clientpositive/decimal_trailing.q.out PRE-CREATION
ql/src/test/results/clientpositive/decimal_udf.q.out 02a0caa
ql/src/test/results/clientpositive/literal_decimal.q.out 2f2df6a
ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out 890cb2c
ql/src/test/results/clientpositive/parquet_decimal.q.out b2d542f
ql/src/test/results/clientpositive/parquet_decimal1.q.out 9ff0950
ql/src/test/results/clientpositive/serde_regex.q.out e231a09
ql/src/test/results/clientpositive/tez/vector_data_types.q.out 4954825
ql/src/test/results/clientpositive/tez/vector_decimal_aggregate.q.out 437e830
ql/src/test/results/clientpositive/udf_case.q.out 6c186bd
ql/src/test/results/clientpositive/udf_when.q.out cbb1210
ql/src/test/results/clientpositive/vector_between_in.q.out 78e340b
ql/src/test/results/clientpositive/vector_data_types.q.out 007f4e8
ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out 2c4d552
ql/src/test/results/clientpositive/vector_decimal_cast.q.out a508732
ql/src/test/results/clientpositive/vector_decimal_expressions.q.out 094eb8e
ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out 71a3def
ql/src/test/results/clientpositive/vector_decimal_math_funcs.q.out 717e81a
ql/src/test/results/clientpositive/windowing_decimal.q.out 88d11af
ql/src/test/results/clientpositive/windowing_navfn.q.out 95d7942
ql/src/test/results/clientpositive/windowing_rank.q.out 9976fdb
serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 523ad7d
Diff: https://reviews.apache.org/r/24467/diff/
Testing
-------
Thanks,
Sergio Pena