You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Dawid Weiss (Created) (JIRA)" <ji...@apache.org> on 2012/03/04 20:03:58 UTC
[jira] [Created] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
LuceneTestCase should check for modifications on System properties
------------------------------------------------------------------
Key: LUCENE-3847
URL: https://issues.apache.org/jira/browse/LUCENE-3847
Project: Lucene - Java
Issue Type: Improvement
Components: general/test
Reporter: Dawid Weiss
Assignee: Dawid Weiss
Priority: Minor
Fix For: 3.6, 4.0
- fail the test if changes have been detected.
- revert the state of system properties before the suite.
- cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Weiss resolved LUCENE-3847.
---------------------------------
Resolution: Fixed
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222208#comment-13222208 ]
Uwe Schindler commented on LUCENE-3847:
---------------------------------------
As far as I remember, the main problem with the Map interface in Properties is the values coming from the parent object (passed in Parameter). When you wrap another properties object with one that has the other one as "defaults" given in ctor, then your are fcked up if you are using the Map interface. Which is not the case for system properties, but that's not guaranteed (e.g. the Java JVM could set some basic properties in another Properties object and make the changes available only through the overlayed properties object).
To fix the "defaults" problem I would go with the Enumeration<?> (works in Java 5, too) in a "for(Enumeration<?> e=propertyNames(); e.hasMoreElements();)" loop.
If you use the Set interface, the inherited props would not have been seen and the system may *delete* properties which are in a parent/"defaults" properties object.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222224#comment-13222224 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
Now I remember what it was that I had a problem with. Properties has the notion of "defaults" so it falls back to another Properties by default if the key is not present. Unfortunately get() is not overridden in Properties (and everything else is) so things like propertyNames or getProperty will return a value from the fallback set, but get() won't.
{code}
public static void main(String[] args) {
Properties defaults = new Properties();
Properties p = new Properties(defaults);
String key = "custom-key";
String value = "value";
defaults.put(key, value);
for (Enumeration<?> e = p.propertyNames(); e.hasMoreElements();) {
Object currentKey = e.nextElement();
if (currentKey == key) {
System.out.println("Default key found in propertyNames(), but...");
System.out.println("p.get()=" + p.get(key));
System.out.println("p.getProperty()=" + p.getProperty(key));
}
}
}
{code}
You can easily corrupt other programs by inserting Object values into the system property set -- any enumeration will then fail with a classcast. Still don't remember where this caused a problem but it definitely was.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235592#comment-13235592 ]
Robert Muir commented on LUCENE-3847:
-------------------------------------
Strangely i trip the timezone issue when running any solr tests from Eclipse... but not lucene tests?
E.g. if i run TestDemo from lucene its fine, but if i run TestRussianFilter (org.apache.solr.analysis) then i hit:
{noformat}
java.lang.AssertionError: System properties invariant violated.
Different values:
[old]user.timezone=
[new]user.timezone=America/New_York
at org.apache.lucene.util.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:46)
at org.junit.rules.RunRules.evaluate(RunRules.java:18)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
{noformat}
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222209#comment-13222209 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
Yeah, it might have been that that I experienced. So back to enumeration we go :(
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3847) LuceneTestCase should
check for modifications on System properties
Posted by "Uwe Schindler (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222217#comment-13222217 ]
Uwe Schindler edited comment on LUCENE-3847 at 3/5/12 8:30 AM:
---------------------------------------------------------------
About your commit: It should be getProperty() [without cast] and not get()... Otherwise the defaults are again fcked up :-)
was (Author: thetaphi):
About your commit: It should be getProperty() and not get()... Otherwise the defaults are again fcked up :-)
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235755#comment-13235755 ]
Robert Muir commented on LUCENE-3847:
-------------------------------------
{quote}
I suggest that we just ignore user.timezone as it is triggered from multiple locations and doesn't seem that important?
{quote}
+1, we know its a side effect of our testcase itself randomizing the locale/timezone...
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222230#comment-13222230 ]
Uwe Schindler commented on LUCENE-3847:
---------------------------------------
No prob. That is exactly the problem I wanted to prevent with the Enumeration and getProperty(). Code using those 2 functions is the only correct one to list all properties... :(
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Mark Miller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222361#comment-13222361 ]
Mark Miller commented on LUCENE-3847:
-------------------------------------
This is great Dawid, thanks!
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222031#comment-13222031 ]
Uwe Schindler commented on LUCENE-3847:
---------------------------------------
+1
Properties implements java.util.Map<Object,Object>, clone as Map can simply be a "new WhateverMap(System.getProperties())". Although it's <Object,Object>, it should only contain Strings... Can we be sure?
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236069#comment-13236069 ]
Robert Muir commented on LUCENE-3847:
-------------------------------------
Thanks Dawid... these tests are now working in my IDE
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222225#comment-13222225 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
bq. As far as I remember, the main problem with the Map interface in Properties is the values coming from the parent "defaults" object.
Exactly, I'm kind of slow today.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222064#comment-13222064 ]
Uwe Schindler commented on LUCENE-3847:
---------------------------------------
bq. I don't know, to be honest. I didn't want to experiment because I remember being scalded at some point in my past when I used Map interface to manipulate system properties and in certain circumstances things didn't work as they should. I can't remember the details now, unfortunately.
For copying you are already using the map interface (retrieving entrySet). For read access this is not a problem, but the whole Java API implementing Map is broken. Implementing the Map interface, which allows to put Object keys/values is unfortunately a no-go. But doing "new TreeMap<String,String>((Map<String,String>) properties)" is fine (with SuppressWarnings because of the cast) - because the putAll method of TreeMap is implemented exactly as your loop.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235995#comment-13235995 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
Applied a fix for this. user.timezone is ignored (and is not reset).
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235710#comment-13235710 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
Well... something is changing it, the question is what it is. I'll take a look.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222202#comment-13222202 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
Yeah, I know. I actually felt bad about entrySet too -- I think the safest way would be to use enumeration, but it felt ancient. I'll leave as is if you don't mind. It's a bit more explicit, but won't hurt anybody I think.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222013#comment-13222013 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
I've implemented this invariant and it works as a charm. Did you know TimeZone.getDefault() has a side-effect of setting (!) user.timezone system property? If you did, I'll buy you a beer next time we meet :)
Anyway, lots of Solr tests leave behind system properties. Instead of trying to fix them one by one I went kind of the easy route and created a class and test rule that simply reverts all system properties from before the entry scope. This has been applied to AbstractSolrTestCase and SolrTestCaseJ4 and since these are subclasses of LuceneTestCase, the invariant will always hold, no matter what.
If Solr folks wish to fix tests one by one (which may be a good idea or a bad idea -- there's lots of them), then comment out these two:
{code}
@ClassRule
public static TestRule solrClassRules =
RuleChain.outerRule(new SystemPropertiesRestoreRule());
@Rule
public TestRule solrTestRules =
RuleChain.outerRule(new SystemPropertiesRestoreRule());
{code}
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222223#comment-13222223 ]
Uwe Schindler commented on LUCENE-3847:
---------------------------------------
Horrible!!! I just say: die, die, die
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222206#comment-13222206 ]
Uwe Schindler commented on LUCENE-3847:
---------------------------------------
I don't mind, I think it's fine. But I had the same problem like you when I used the Properties class, it always feels bad and some things are not working at all.
This comment in Javadocs for public Set<String> stringPropertyNames() makes me nervous, too:
{quote}
Returns a set of keys in this property list where the key and its corresponding value are strings, including distinct keys in the default property list if a key of the same name has not already been found from the main properties list. Properties whose key or value is not of type String are omitted.
The returned set is not backed by the Properties object. Changes to this Properties are not reflected in the set, or vice versa.
Returns:
a set of keys in this property list where the key and its corresponding value are strings, including the keys in the default property list.
Since:
1.6
{quote}
This method is available since Java 6, so this would be the "most correct" solution. Retrieve the set, iterate via advanced for-loop and use getProperty(). But that does not work for Lucene 3.x.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235749#comment-13235749 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
I know what's changing it. Eh. So -- there is a warning being printed:
{noformat}
Mar 22, 2012 6:20:33 PM org.apache.solr.core.Config parseLuceneVersionString
WARNING: You should not use LUCENE_CURRENT as luceneMatchVersion property: if you use this setting, and then Solr upgrades to a newer release of Lucene, sizable changes may happen. If precise back compatibility is important then you should instead explicitly specify an actual Lucene version.
Mar 22, 2012 6:20:33 PM org.apache.solr.analysis.BaseTokenStreamFactory warnDeprecated
WARNING: RussianLetterTokenizerFactory is deprecated. Use StandardTokenizerFactory instead.
{noformat}
These warnings go through Java logging and this in turn is localized (date format, "warning" info, etc.). This in turn asks for the default TimeZone and this in turn sets the system property (I mentioned it a while ago).
I suggest that we just ignore user.timezone as it is triggered from multiple locations and doesn't seem that important?
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222037#comment-13222037 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
I don't know, to be honest. I didn't want to experiment because I remember being scalded at some point in my past when I used Map interface to manipulate system properties and in certain circumstances things didn't work as they should. I can't remember the details now, unfortunately.
As for non Strings and nulls -- I assume only System.setProperty/clearProperty is used to manipulate the map; if so, it should only contain Strings and it should have non-null keys and values.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Weiss updated LUCENE-3847:
--------------------------------
Attachment: LUCENE-3847.patch
Patch with changes.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222217#comment-13222217 ]
Uwe Schindler commented on LUCENE-3847:
---------------------------------------
About your commit: It should be getProperty() and not get()... Otherwise the defaults are again fcked up :-)
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3847) LuceneTestCase should
check for modifications on System properties
Posted by "Uwe Schindler (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222208#comment-13222208 ]
Uwe Schindler edited comment on LUCENE-3847 at 3/5/12 8:09 AM:
---------------------------------------------------------------
As far as I remember, the main problem with the Map interface in Properties is the values coming from the parent "defaults" object. When you wrap another properties object with one that has the other one as "defaults" given in ctor, then your are fcked up if you are using the Map interface. Which is not the case for system properties, but that's not guaranteed (e.g. the Java JVM could set some basic properties in another Properties object and make the changes available only through the overlayed properties object).
To fix the "defaults" problem I would go with the Enumeration<?> (works in Java 5, too) in a "for(Enumeration<?> e=propertyNames(); e.hasMoreElements();)" loop.
If you use the Set interface, the inherited props would not have been seen and the system may *delete* properties which are in a parent/"defaults" properties object.
was (Author: thetaphi):
As far as I remember, the main problem with the Map interface in Properties is the values coming from the parent object (passed in Parameter). When you wrap another properties object with one that has the other one as "defaults" given in ctor, then your are fcked up if you are using the Map interface. Which is not the case for system properties, but that's not guaranteed (e.g. the Java JVM could set some basic properties in another Properties object and make the changes available only through the overlayed properties object).
To fix the "defaults" problem I would go with the Enumeration<?> (works in Java 5, too) in a "for(Enumeration<?> e=propertyNames(); e.hasMoreElements();)" loop.
If you use the Set interface, the inherited props would not have been seen and the system may *delete* properties which are in a parent/"defaults" properties object.
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3847) LuceneTestCase should
check for modifications on System properties
Posted by "Dawid Weiss (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222013#comment-13222013 ]
Dawid Weiss edited comment on LUCENE-3847 at 3/4/12 9:22 PM:
-------------------------------------------------------------
I've implemented this invariant and it works like a charm. Did you know TimeZone.getDefault() has a side-effect of setting (!) user.timezone system property? If you did, I'll buy you a beer next time we meet :)
Anyway, lots of Solr tests leave behind system properties. Instead of trying to fix them one by one I went kind of the easy route and created a class and test rule that simply reverts all system properties from before the entry scope. This has been applied to AbstractSolrTestCase and SolrTestCaseJ4 and since these are subclasses of LuceneTestCase, the invariant will always hold, no matter what.
If Solr folks wish to fix tests one by one (which may be a good idea or a bad idea -- there's lots of them), then comment out these two:
{code}
@ClassRule
public static TestRule solrClassRules =
RuleChain.outerRule(new SystemPropertiesRestoreRule());
@Rule
public TestRule solrTestRules =
RuleChain.outerRule(new SystemPropertiesRestoreRule());
{code}
was (Author: dweiss):
I've implemented this invariant and it works as a charm. Did you know TimeZone.getDefault() has a side-effect of setting (!) user.timezone system property? If you did, I'll buy you a beer next time we meet :)
Anyway, lots of Solr tests leave behind system properties. Instead of trying to fix them one by one I went kind of the easy route and created a class and test rule that simply reverts all system properties from before the entry scope. This has been applied to AbstractSolrTestCase and SolrTestCaseJ4 and since these are subclasses of LuceneTestCase, the invariant will always hold, no matter what.
If Solr folks wish to fix tests one by one (which may be a good idea or a bad idea -- there's lots of them), then comment out these two:
{code}
@ClassRule
public static TestRule solrClassRules =
RuleChain.outerRule(new SystemPropertiesRestoreRule());
@Rule
public TestRule solrTestRules =
RuleChain.outerRule(new SystemPropertiesRestoreRule());
{code}
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3847) LuceneTestCase should check for
modifications on System properties
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222220#comment-13222220 ]
Dawid Weiss commented on LUCENE-3847:
-------------------------------------
Right, good catch. Properties are seriously messed up, aren't they?
> LuceneTestCase should check for modifications on System properties
> ------------------------------------------------------------------
>
> Key: LUCENE-3847
> URL: https://issues.apache.org/jira/browse/LUCENE-3847
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3847.patch
>
>
> - fail the test if changes have been detected.
> - revert the state of system properties before the suite.
> - cleanup after the suite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org