You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2017/10/12 18:16:02 UTC
Review Request 62942: Bump the minimum java version to 8
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62942/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan kumar kalvagadda.
Bugs: sentry-1893
https://issues.apache.org/jira/browse/sentry-1893
Repository: sentry
Description
-------
Bump the version of Java to JDK8 as minmum.
Diffs
-----
pom.xml aa422a042e1496d429180122bde14bb4edb26906
Diff: https://reviews.apache.org/r/62942/diff/1/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 62942: Bump the minimum java version to 8
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62942/#review188032
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 13, 2017, 6:30 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62942/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 6:30 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan kumar kalvagadda.
>
>
> Bugs: sentry-1893
> https://issues.apache.org/jira/browse/sentry-1893
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump the version of Java to JDK8 as minmum.
>
>
> Diffs
> -----
>
> pom.xml a02891223417eccd3976d97d247c8fcb626afa78
>
>
> Diff: https://reviews.apache.org/r/62942/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 62942: Bump the minimum java version to 8
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62942/
-----------------------------------------------------------
(Updated Oct. 13, 2017, 6:30 p.m.)
Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan kumar kalvagadda.
Changes
-------
Removed google error prone.
Bugs: sentry-1893
https://issues.apache.org/jira/browse/sentry-1893
Repository: sentry
Description
-------
Bump the version of Java to JDK8 as minmum.
Diffs (updated)
-----
pom.xml a02891223417eccd3976d97d247c8fcb626afa78
Diff: https://reviews.apache.org/r/62942/diff/2/
Changes: https://reviews.apache.org/r/62942/diff/1-2/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 62942: Bump the minimum java version to 8
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
> On Oct. 12, 2017, 6:56 p.m., Alexander Kolbasov wrote:
> > You also need to update version for com.google.errorprone
I left a comment on the jira about it.
I couldn't bump the google_error_prone dependency to any one that uses Java8 because it was causing IncompatibleClassChangeError when closing the transactions on the SentryStore. I tried from 2.0.9 to 2.1.1 and it has the same failures.
I couldn't figure out how to solve it. I left the current version, and sentry was working ok with java8.
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62942/#review187835
-----------------------------------------------------------
On Oct. 12, 2017, 6:16 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62942/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 6:16 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan kumar kalvagadda.
>
>
> Bugs: sentry-1893
> https://issues.apache.org/jira/browse/sentry-1893
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump the version of Java to JDK8 as minmum.
>
>
> Diffs
> -----
>
> pom.xml aa422a042e1496d429180122bde14bb4edb26906
>
>
> Diff: https://reviews.apache.org/r/62942/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 62942: Bump the minimum java version to 8
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62942/#review187835
-----------------------------------------------------------
You also need to update version for com.google.errorprone
- Alexander Kolbasov
On Oct. 12, 2017, 6:16 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62942/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 6:16 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan kumar kalvagadda.
>
>
> Bugs: sentry-1893
> https://issues.apache.org/jira/browse/sentry-1893
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Bump the version of Java to JDK8 as minmum.
>
>
> Diffs
> -----
>
> pom.xml aa422a042e1496d429180122bde14bb4edb26906
>
>
> Diff: https://reviews.apache.org/r/62942/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>