You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/25 18:10:18 UTC
[GitHub] [kafka] divijvaidya opened a new pull request, #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page
divijvaidya opened a new pull request, #12438:
URL: https://github.com/apache/kafka/pull/12438
As per the [discussion in the community](https://lists.apache.org/thread/p24xvbf8nkvxpbj668vc0g3x3lojsnk4), we want to replace the embedded YouTube videos with hyperlinks to satisfy the [ASF privacy policy](https://privacy.apache.org/faq/committers.html).
This code change replaces the embedded videos from the streams web page on the website with hyperlinks.
**Before**
**After**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page
Posted by GitBox <gi...@apache.org>.
mimaison merged PR #12438:
URL: https://github.com/apache/kafka/pull/12438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12438:
URL: https://github.com/apache/kafka/pull/12438#issuecomment-1194568297
@bbejeck @mimaison This is the second to last PR before we can close https://issues.apache.org/jira/browse/TINKERPOP-2738. The last one will migrate this code to website with 33 version.
Kindly review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on a diff in pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page
Posted by GitBox <gi...@apache.org>.
mimaison commented on code in PR #12438:
URL: https://github.com/apache/kafka/pull/12438#discussion_r930015414
##########
docs/streams/index.html:
##########
@@ -35,32 +35,25 @@ <h1>Kafka Streams</h1>
</div>
<h3 class="streams_intro">The easiest way to write mission-critical real-time applications and microservices</h3>
<p class="streams__description">Kafka Streams is a client library for building applications and microservices, where the input and output data are stored in Kafka clusters. It combines the simplicity of writing and deploying standard Java and Scala applications on the client side with the benefits of Kafka's server-side cluster technology.</p>
+ <hr class="separator">
+ <h3>VIDEO TOUR OF THE STREAMS API</h3>
<div class="video__series__grid">
- <div class="yt__video__block">
- <div class="yt__video__inner__block">
- <iframe class="yt_series video_1 active" style="display:block" src="https://www.youtube.com/embed/Z3JKCLG3VP4?rel=0&showinfo=0&end=602" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_2" src="https://www.youtube.com/embed/LxxeXI1mPKo?rel=0&showinfo=0&end=622" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_3" src="https://www.youtube.com/embed/7JYEEx7SBuE?rel=0&showinfo=0end=557" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_4" src="https://www.youtube.com/embed/3kJgYIkAeHs?rel=0&showinfo=0&end=564" frameborder="0" allowfullscreen></iframe>
- </div>
- </div>
- <div class="video__block">
- <h3>TOUR OF THE STREAMS API</h3>
- <div class="video__list">
- <p class="video__item video_list_1 active" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_1').show();">
- <span class="video-number">1</span><span class="video__text">Intro to Streams</span>
- </p>
- <p class="video__item video_list_2" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_2').show();">
- <span class="video-number">2</span><span class="video__text">Creating a Streams Application</span>
- </p>
- <p class="video__item video_list_3" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_3').show();">
- <span class="video-number">3</span><span class="video__text">Transforming Data Pt. 1</span>
- </p>
- <p class="video__item video_list_4" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_4').show();">
- <span class="video-number">4</span><span class="video__text">Transforming Data Pt. 2</span>
- </p>
- </div>
- </div>
+ <div class="video__block">
+ <div class="video__list">
+ <p class="video__item video_list_1 active">
+ <span class="video-number">1</span><a href="https://www.youtube.com/embed/Z3JKCLG3VP4"><span class="video__text">Intro to Streams</span></a>
+ </p>
+ <p class="video__item video_list_2 active">
+ <span class="video-number">2</span><a href="https://www.youtube.com/embed/LxxeXI1mPKo"><span class="video__text">Creating a Streams Application</span></a>
+ </p>
+ <p class="video__item video_list_3 active">
+ <span class="video-number">3</span><a href="https://www.youtube.com/embed/7JYEEx7SBuE"><span class="video__text">Transforming Data Pt. 1</span></a>
+ </p>
+ <p class="video__item video_list_4 active">
+ <span class="video-number">4</span><a href="https://www.youtube.com/embed/3kJgYIkAeHs"><span class="video__text">Transforming Data Pt. 11</span></a>
Review Comment:
Can we keep `Transforming Data Pt. 2` instead of `Transforming Data Pt. 11`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #12438:
URL: https://github.com/apache/kafka/pull/12438#discussion_r930066946
##########
docs/streams/index.html:
##########
@@ -35,32 +35,25 @@ <h1>Kafka Streams</h1>
</div>
<h3 class="streams_intro">The easiest way to write mission-critical real-time applications and microservices</h3>
<p class="streams__description">Kafka Streams is a client library for building applications and microservices, where the input and output data are stored in Kafka clusters. It combines the simplicity of writing and deploying standard Java and Scala applications on the client side with the benefits of Kafka's server-side cluster technology.</p>
+ <hr class="separator">
+ <h3>VIDEO TOUR OF THE STREAMS API</h3>
<div class="video__series__grid">
- <div class="yt__video__block">
- <div class="yt__video__inner__block">
- <iframe class="yt_series video_1 active" style="display:block" src="https://www.youtube.com/embed/Z3JKCLG3VP4?rel=0&showinfo=0&end=602" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_2" src="https://www.youtube.com/embed/LxxeXI1mPKo?rel=0&showinfo=0&end=622" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_3" src="https://www.youtube.com/embed/7JYEEx7SBuE?rel=0&showinfo=0end=557" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_4" src="https://www.youtube.com/embed/3kJgYIkAeHs?rel=0&showinfo=0&end=564" frameborder="0" allowfullscreen></iframe>
- </div>
- </div>
- <div class="video__block">
- <h3>TOUR OF THE STREAMS API</h3>
- <div class="video__list">
- <p class="video__item video_list_1 active" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_1').show();">
- <span class="video-number">1</span><span class="video__text">Intro to Streams</span>
- </p>
- <p class="video__item video_list_2" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_2').show();">
- <span class="video-number">2</span><span class="video__text">Creating a Streams Application</span>
- </p>
- <p class="video__item video_list_3" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_3').show();">
- <span class="video-number">3</span><span class="video__text">Transforming Data Pt. 1</span>
- </p>
- <p class="video__item video_list_4" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_4').show();">
- <span class="video-number">4</span><span class="video__text">Transforming Data Pt. 2</span>
- </p>
- </div>
- </div>
+ <div class="video__block">
+ <div class="video__list">
+ <p class="video__item video_list_1 active">
+ <span class="video-number">1</span><a href="https://www.youtube.com/embed/Z3JKCLG3VP4"><span class="video__text">Intro to Streams</span></a>
+ </p>
+ <p class="video__item video_list_2 active">
+ <span class="video-number">2</span><a href="https://www.youtube.com/embed/LxxeXI1mPKo"><span class="video__text">Creating a Streams Application</span></a>
+ </p>
+ <p class="video__item video_list_3 active">
+ <span class="video-number">3</span><a href="https://www.youtube.com/embed/7JYEEx7SBuE"><span class="video__text">Transforming Data Pt. 1</span></a>
+ </p>
+ <p class="video__item video_list_4 active">
+ <span class="video-number">4</span><a href="https://www.youtube.com/embed/3kJgYIkAeHs"><span class="video__text">Transforming Data Pt. 11</span></a>
Review Comment:
Of course. Although the current website [still mentions "Pt. 11"](https://kafka.apache.org/documentation/streams/) but I guess it's because we haven't deployed the latest code for this page over there.
I have changed it to 2.
Also, please let me know what is the next step to "deploy" the change into kafka-site?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on a diff in pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page
Posted by GitBox <gi...@apache.org>.
mimaison commented on code in PR #12438:
URL: https://github.com/apache/kafka/pull/12438#discussion_r930099870
##########
docs/streams/index.html:
##########
@@ -35,32 +35,25 @@ <h1>Kafka Streams</h1>
</div>
<h3 class="streams_intro">The easiest way to write mission-critical real-time applications and microservices</h3>
<p class="streams__description">Kafka Streams is a client library for building applications and microservices, where the input and output data are stored in Kafka clusters. It combines the simplicity of writing and deploying standard Java and Scala applications on the client side with the benefits of Kafka's server-side cluster technology.</p>
+ <hr class="separator">
+ <h3>VIDEO TOUR OF THE STREAMS API</h3>
<div class="video__series__grid">
- <div class="yt__video__block">
- <div class="yt__video__inner__block">
- <iframe class="yt_series video_1 active" style="display:block" src="https://www.youtube.com/embed/Z3JKCLG3VP4?rel=0&showinfo=0&end=602" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_2" src="https://www.youtube.com/embed/LxxeXI1mPKo?rel=0&showinfo=0&end=622" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_3" src="https://www.youtube.com/embed/7JYEEx7SBuE?rel=0&showinfo=0end=557" frameborder="0" allowfullscreen></iframe>
- <iframe class="yt_series video_4" src="https://www.youtube.com/embed/3kJgYIkAeHs?rel=0&showinfo=0&end=564" frameborder="0" allowfullscreen></iframe>
- </div>
- </div>
- <div class="video__block">
- <h3>TOUR OF THE STREAMS API</h3>
- <div class="video__list">
- <p class="video__item video_list_1 active" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_1').show();">
- <span class="video-number">1</span><span class="video__text">Intro to Streams</span>
- </p>
- <p class="video__item video_list_2" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_2').show();">
- <span class="video-number">2</span><span class="video__text">Creating a Streams Application</span>
- </p>
- <p class="video__item video_list_3" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_3').show();">
- <span class="video-number">3</span><span class="video__text">Transforming Data Pt. 1</span>
- </p>
- <p class="video__item video_list_4" onclick="$('.video__item').removeClass('active'); $(this).addClass('active');$('.yt_series').hide();$('.video_4').show();">
- <span class="video-number">4</span><span class="video__text">Transforming Data Pt. 2</span>
- </p>
- </div>
- </div>
+ <div class="video__block">
+ <div class="video__list">
+ <p class="video__item video_list_1 active">
+ <span class="video-number">1</span><a href="https://www.youtube.com/embed/Z3JKCLG3VP4"><span class="video__text">Intro to Streams</span></a>
+ </p>
+ <p class="video__item video_list_2 active">
+ <span class="video-number">2</span><a href="https://www.youtube.com/embed/LxxeXI1mPKo"><span class="video__text">Creating a Streams Application</span></a>
+ </p>
+ <p class="video__item video_list_3 active">
+ <span class="video-number">3</span><a href="https://www.youtube.com/embed/7JYEEx7SBuE"><span class="video__text">Transforming Data Pt. 1</span></a>
+ </p>
+ <p class="video__item video_list_4 active">
+ <span class="video-number">4</span><a href="https://www.youtube.com/embed/3kJgYIkAeHs"><span class="video__text">Transforming Data Pt. 11</span></a>
Review Comment:
As we want to website fixed asap, I think the best is to open a similar PR against kafka-site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org