[jira] [Commented] (SINGA-44) A bug when reseting metric values

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SINGA-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693148#comment-14693148 ] 

ASF subversion and git services commented on SINGA-44:
------------------------------------------------------

Commit 4446889df52924b29f28d88b797d661b0acb1b3e in incubator-singa's branch refs/heads/master from Wei Wang
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=4446889 ]

SINGA-44 A bug when reseting metric values

When reseting the values of Metric object, we didn't use reference which made the resetting invalid.
Fixed the bug by using reference.


> A bug when reseting metric values
> ---------------------------------
>
>                 Key: SINGA-44
>                 URL: https://issues.apache.org/jira/browse/SINGA-44
>             Project: Singa
>          Issue Type: Bug
>            Reporter: Zheng Kaiping
>
> In /src/utils/common.cc, inside the loop of  "void Metric::Reset()" function, the reference of entry needs to be reset instead of the variable.
> Previous:
> for(auto e : entry_)
> Fix the bug:
> for(auto &e : entry_) 
> If we use the previous reset method, the metric value is output as an average value for all minibatches. Then even if we have set the frequency to output metrics in job.conf (which means we need the average metric values every several minibatches), the output results are incorrect. Therefore, the previous reset method causes invalid metric value resetting operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)