You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/08/08 10:12:16 UTC
[PR] [SPARK-58661][SQL][DOCS] Document return values and fix stale column references in DataFrameStatFunctions [spark]
uros-b opened a new pull request, #57868:
URL: https://github.com/apache/spark/pull/57868
### What changes were proposed in this pull request?
Two scaladoc fixes in `DataFrameStatFunctions`:
1. Adds the missing `@return` tag to the four `bloomFilter` overloads.
2. Corrects the `@return` text of the two `countMinSketch(col: Column, ...)` overloads, which described the result as being over column `colName` even though those overloads declare `col`.
### Why are the changes needed?
The `countMinSketch` overloads all document their return value while the parallel `bloomFilter` overloads document none, so the published API docs are inconsistent between two families of methods that the file otherwise describes in parallel wording. Each added tag names the parameter its own overload declares, alternating `colName`/`col` to match the four signatures.
The two stale `colName` references are a copy-paste artifact of the unified Scala interface refactor: the text was carried over from the `colName: String` overloads without being updated for the `Column` ones. The `colName` overloads themselves are correct and are left untouched.
### Does this PR introduce _any_ user-facing change?
No, other than the corrected API documentation.
### How was this patch tested?
Scaladoc only, so no behavior to test. Stripping comments from the file before and after the change yields byte-identical source, confirming no signature or code change and no binary compatibility impact.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58661][SQL][DOCS] Document return values and fix stale column references in DataFrameStatFunctions [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57868: [SPARK-58661][SQL][DOCS] Document return values and fix stale column references in DataFrameStatFunctions
URL: https://github.com/apache/spark/pull/57868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58661][SQL][DOCS] Document return values and fix stale column references in DataFrameStatFunctions [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57868:
URL: https://github.com/apache/spark/pull/57868#issuecomment-5233705709
Thank you @dongjoon-hyun!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58661][SQL][DOCS] Document return values and fix stale column references in DataFrameStatFunctions [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57868:
URL: https://github.com/apache/spark/pull/57868#issuecomment-5233708951
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/e9fbec7b538b8f5e4105c8dc030e1e510af87974
- merged into branch-4.x https://github.com/apache/spark/commit/d160da49d54b683b5963a0814d8bdf69037889ae
- merged into branch-4.3 https://github.com/apache/spark/commit/45f5008643b5b3d375659cb4df875a582aa5e620
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org