You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Ishaan29 (via GitHub)" <gi...@apache.org> on 2023/05/18 01:30:23 UTC
[GitHub] [eventmesh] Ishaan29 opened a new pull request, #3954: ISSUE #3900 Removed Additional Null Check
Ishaan29 opened a new pull request, #3954:
URL: https://github.com/apache/eventmesh/pull/3954
ISSUE #3900
Removed additional null check as both Objects.requireNonNull and later explicit null check is doing the same thing.
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3900.
### Motivation
* as the issue suggest, there is an extra null check that is exhibiting the same functionality. as the Objects.requireNonNull throws NPE if the object is null. the later null check is redundant the execution won't reach the later check.
### Modifications
* Removed the additional redundant null check.
### Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why? simple code refactoring.
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Ishaan29 commented on pull request #3954: ISSUE #3900 Removed Additional Null Check
Posted by "Ishaan29 (via GitHub)" <gi...@apache.org>.
Ishaan29 commented on PR #3954:
URL: https://github.com/apache/eventmesh/pull/3954#issuecomment-1552410160
hey @xwm1992 ,
could you please review this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Ishaan29 commented on pull request #3954: ISSUE #3900 Removed Additional Null Check
Posted by "Ishaan29 (via GitHub)" <gi...@apache.org>.
Ishaan29 commented on PR #3954:
URL: https://github.com/apache/eventmesh/pull/3954#issuecomment-1553284409
hey @Alonexc @mxsm ,
as I am new here, I am not sure as to how should we go about merging the request,
could you please let me know if we need more approvals, or essentially what are the nest steps.
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3954: [ISSUE #3900] Removed Additional Null Check
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3954:
URL: https://github.com/apache/eventmesh/pull/3954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3954: ISSUE #3900 Removed Additional Null Check
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3954:
URL: https://github.com/apache/eventmesh/pull/3954#issuecomment-1553846739
@Ishaan29 Once the ci check is passed, it can be merged in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Ishaan29 commented on pull request #3954: ISSUE #3900 Removed Additional Null Check
Posted by "Ishaan29 (via GitHub)" <gi...@apache.org>.
Ishaan29 commented on PR #3954:
URL: https://github.com/apache/eventmesh/pull/3954#issuecomment-1555836861
hey @Alonexc ,
how do we trigger CI ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3954: [ISSUE #3900] Removed Additional Null Check
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3954:
URL: https://github.com/apache/eventmesh/pull/3954#issuecomment-1556426985
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3954?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3954](https://app.codecov.io/gh/apache/eventmesh/pull/3954?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c0f9473) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/3bf8aedca2e32aefdf750487a452418b4e5272b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3bf8aed) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head c0f9473 differs from pull request most recent head 3144f81. Consider uploading reports for the commit 3144f81 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3954 +/- ##
============================================
- Coverage 13.93% 13.92% -0.01%
Complexity 1290 1290
============================================
Files 571 571
Lines 28803 28794 -9
Branches 2807 2793 -14
============================================
- Hits 4013 4009 -4
+ Misses 24414 24410 -4
+ Partials 376 375 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3954?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...mesh/common/protocol/catalog/protos/Operation.java](https://app.codecov.io/gh/apache/eventmesh/pull/3954?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9jYXRhbG9nL3Byb3Rvcy9PcGVyYXRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3954/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org