You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/04 23:06:55 UTC

[GitHub] [superset] michellethomas commented on a change in pull request #14995: fix: adding additional configs and colors for queryHistory

michellethomas commented on a change in pull request #14995:
URL: https://github.com/apache/superset/pull/14995#discussion_r645897900



##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.jsx
##########
@@ -259,10 +273,12 @@ const QueryTable = props => {
             placement="bottom"
           >
             <span>
-              <StatusIcon
-                name={statusAttributes[q.state].config.name}
-                status={statusAttributes[q.state].config.status}
-              />
+              {q.state && (

Review comment:
       Is it possible for q.state to be undefined? You added this when we were testing, is this still needed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org