You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/08 07:54:08 UTC

[GitHub] [dolphinscheduler] dailidong commented on a change in pull request #6723: Refactor alert plugins and simplify its usage

dailidong commented on a change in pull request #6723:
URL: https://github.com/apache/dolphinscheduler/pull/6723#discussion_r744474312



##########
File path: dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java
##########
@@ -31,23 +31,19 @@
 
 import java.io.IOException;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.fasterxml.jackson.annotation.JsonProperty;
 
-public class FeiShuSender {
-
-    private static final Logger logger = LoggerFactory.getLogger(FeiShuSender.class);
-
-    private String url;
+import lombok.Data;
+import lombok.extern.slf4j.Slf4j;

Review comment:
       don't use lombok, thx




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org