You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "code4wt (GitHub)" <gi...@apache.org> on 2018/11/05 13:27:41 UTC
[GitHub] [incubator-dubbo] code4wt opened pull request #2740:
Simplify the code of StringUtils to make it more graceful.
## What is the purpose of the change
Simplify the code of StringUtils to make it more graceful.
## Brief changelog
Modified files:
dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
dubbo-common/src/test/java/org/apache/dubbo/common/utils/StringUtilsTest.java
New Files:
dubbo-common/src/main/java/org/apache/dubbo/common/utils/ArrayUtils.java
dubbo-common/src/test/java/org/apache/dubbo/common/utils/ArrayUtilsTest.java
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2740 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2740:
Simplify the code of StringUtils to make it more graceful.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2740?src=pr&el=h1) Report
> Merging [#2740](https://codecov.io/gh/apache/incubator-dubbo/pull/2740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/2284ede0f14fae6212fac54a2e04a12534446da7?src=pr&el=desc) will **increase** coverage by `1.12%`.
> The diff coverage is `67.64%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2740?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2740 +/- ##
=========================================
+ Coverage 62.38% 63.5% +1.12%
=========================================
Files 598 577 -21
Lines 27911 25920 -1991
Branches 4828 4541 -287
=========================================
- Hits 17412 16461 -951
+ Misses 8233 7299 -934
+ Partials 2266 2160 -106
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2740?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/dubbo/common/utils/ArrayUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQXJyYXlVdGlscy5qYXZh) | `100% <100%> (ø)` | |
| [...ava/org/apache/dubbo/common/utils/StringUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `85.71% <65.62%> (+1.37%)` | :arrow_up: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `76.31% <0%> (-7.9%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `73.58% <0%> (-7.55%)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.78% <0%> (-5.27%)` | :arrow_down: |
| [...ing/exchange/support/header/AbstractTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9BYnN0cmFjdFRpbWVyVGFzay5qYXZh) | `66.66% <0%> (-4.17%)` | :arrow_down: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-4.17%)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `85.71% <0%> (-3.58%)` | :arrow_down: |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNvZGVjQWRhcHRlci5qYXZh) | `53.12% <0%> (-1.57%)` | :arrow_down: |
| [.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTdGF0dXMuamF2YQ==) | `57.89% <0%> (-1.06%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2740/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2740?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2740?src=pr&el=footer). Last update [2284ede...249eb62](https://codecov.io/gh/apache/incubator-dubbo/pull/2740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2740 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #2740:
Simplify the code of StringUtils to make it more graceful.
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
great work, thanks.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2740 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #2740:
Simplify the code of StringUtils to make it more graceful.
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2740 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org