You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/01 17:11:35 UTC
[GitHub] [incubator-inlong] haibo-duan opened a new pull request, #4062: [INLONG-3636][Tubemq] Fix the warnings log during the build
haibo-duan opened a new pull request, #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062
### Title Name: [INLONG-XYZ][component] Title of the pull request
where *XYZ* should be replaced by the actual issue number.
Fix the warnings log of [inlong-tubemq] component during the build .
About #3636
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] haibo-duan commented on a diff in pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build
Posted by GitBox <gi...@apache.org>.
haibo-duan commented on code in PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#discussion_r866111613
##########
inlong-tubemq/tubemq-core/src/main/java/org/apache/inlong/tubemq/corerpc/netty/NettyClientFactory.java:
##########
@@ -235,15 +238,13 @@ private Client createClient(final NodeAddrInfo addressInfo,
conf.getInt(RpcConstants.NETTY_WRITE_HIGH_MARK, -1);
int nettyWriteLowMark =
conf.getInt(RpcConstants.NETTY_WRITE_LOW_MARK, -1);
- if (nettyWriteHighMark > 0) {
- clientBootstrap.option(ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK, nettyWriteHighMark);
- }
- if (nettyWriteLowMark > 0) {
- clientBootstrap.option(ChannelOption.WRITE_BUFFER_LOW_WATER_MARK, nettyWriteLowMark);
+ if (nettyWriteHighMark > 0 && nettyWriteLowMark > 0) {
Review Comment:
In the previous code,if nettyWriteHighMark not set ,the default value is 64 * 1024. if nettyWriteLowMark not set ,the default value is 32 * 1024. I have modified the code, please help me review it. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang commented on a diff in pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#discussion_r865724027
##########
inlong-tubemq/tubemq-core/src/main/java/org/apache/inlong/tubemq/corerpc/netty/NettyClientFactory.java:
##########
@@ -235,15 +238,13 @@ private Client createClient(final NodeAddrInfo addressInfo,
conf.getInt(RpcConstants.NETTY_WRITE_HIGH_MARK, -1);
int nettyWriteLowMark =
conf.getInt(RpcConstants.NETTY_WRITE_LOW_MARK, -1);
- if (nettyWriteHighMark > 0) {
- clientBootstrap.option(ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK, nettyWriteHighMark);
- }
- if (nettyWriteLowMark > 0) {
- clientBootstrap.option(ChannelOption.WRITE_BUFFER_LOW_WATER_MARK, nettyWriteLowMark);
+ if (nettyWriteHighMark > 0 && nettyWriteLowMark > 0) {
Review Comment:
What if the user only needs to modify nettyWriteHighMark or nettyWriteLowMark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#issuecomment-1118352478
@gosonzhang PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang commented on a diff in pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#discussion_r865771036
##########
inlong-tubemq/tubemq-core/src/main/java/org/apache/inlong/tubemq/corerpc/netty/NettyClientFactory.java:
##########
@@ -235,15 +238,13 @@ private Client createClient(final NodeAddrInfo addressInfo,
conf.getInt(RpcConstants.NETTY_WRITE_HIGH_MARK, -1);
int nettyWriteLowMark =
conf.getInt(RpcConstants.NETTY_WRITE_LOW_MARK, -1);
- if (nettyWriteHighMark > 0) {
- clientBootstrap.option(ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK, nettyWriteHighMark);
- }
- if (nettyWriteLowMark > 0) {
- clientBootstrap.option(ChannelOption.WRITE_BUFFER_LOW_WATER_MARK, nettyWriteLowMark);
+ if (nettyWriteHighMark > 0 && nettyWriteLowMark > 0) {
Review Comment:
@haibo-duan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build
Posted by GitBox <gi...@apache.org>.
healchow commented on PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#issuecomment-1114437774
Hello haibo-duan, Thanks for your PR. There are some license errors here, please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#discussion_r864918750
##########
inlong-tubemq/tubemq-manager/src/main/assembly/assembly.xml:
##########
@@ -21,7 +21,6 @@
xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 http://maven.apache.org/xsd/assembly-2.1.0.xsd">
<id>bin</id>
<formats>
- <format>dir</format>
Review Comment:
ditto
##########
inlong-tubemq/tubemq-example/src/main/assembly/assembly.xml:
##########
@@ -18,7 +18,6 @@
<assembly>
<id>demo</id>
<formats>
- <format>dir</format>
Review Comment:
ditto
##########
inlong-tubemq/tubemq-client/src/main/assembly/assembly.xml:
##########
@@ -18,7 +18,6 @@
<assembly>
<id>bin</id>
<formats>
- <format>dir</format>
Review Comment:
here we should keep the dir format, because it may be used in https://github.com/apache/incubator-inlong/blob/master/inlong-distribution/distribution.xm to package the whole binary package.
##########
inlong-tubemq/tubemq-server/src/main/assembly/assembly.xml:
##########
@@ -18,7 +18,6 @@
<assembly>
<id>bin</id>
<formats>
- <format>dir</format>
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4062: [INLONG-3636][TubeMQ] Fix the warning logs during the build
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #4062:
URL: https://github.com/apache/incubator-inlong/pull/4062#discussion_r864918345
##########
inlong-tubemq/tubemq-client/src/main/assembly/assembly.xml:
##########
@@ -18,7 +18,6 @@
<assembly>
<id>bin</id>
<formats>
- <format>dir</format>
Review Comment:
here we should keep the dir format, because it may be used in https://github.com/apache/incubator-inlong/blob/master/inlong-distribution/distribution.xm to package the whole binary tar file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org