You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/09 02:19:25 UTC

[GitHub] [apisix] tokers commented on a change in pull request #4005: feat: support upstream mTLS

tokers commented on a change in pull request #4005:
URL: https://github.com/apache/apisix/pull/4005#discussion_r610275842



##########
File path: apisix/upstream.lua
##########
@@ -279,6 +291,25 @@ function _M.set_by_route(route, api_ctx)
         api_ctx.up_checker = checker
     end
 
+    if up_conf.scheme == "https" and up_conf.tls then

Review comment:
       Shall we also support mTLS for `grpcs` in the future?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org