You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by godfreyhe <gi...@git.apache.org> on 2017/08/22 09:12:09 UTC

[GitHub] flink pull request #4572: [Flink-7243] [connectors] Add ParquetInputFormat

GitHub user godfreyhe opened a pull request:

    https://github.com/apache/flink/pull/4572

    [Flink-7243] [connectors] Add ParquetInputFormat 

    ## What is the purpose of the change
    
    Add ParquetInputFormat to read from parquet files
    
    ## Brief change log
      - *Supports primary parquet types*
      - *Supports reading data with given columns instead of all columns*
      - *Supports reading data with filter*
      - *The return type of ParquetInputFormat supports Row, Tuple, POJO*
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
     - *Added test that validates the correct of input split result with file or directory*
     - *Added test for reading with filter*
     - *Added test for  RowParquetInputFormat/TupleParquetInputFormat/PojoParquetInputFormat*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (JavaDocs)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/godfreyhe/flink FLINK-7243

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4572
    
----
commit a281bbac15cafce40b08e7e0a510e42c07301c82
Author: godfreyhe <go...@163.com>
Date:   2017-07-23T12:20:04Z

    [FLINK-7243] Add ParquetInputFormat

commit 9879922970517ee9d1b0730212e36d607ee508f5
Author: godfreyhe <go...@163.com>
Date:   2017-07-24T13:10:55Z

    change the return type of ParquetSchemaConverter#convertToTypeInformation method, update Tests

commit c3d8a054ff7f831cd99ea525b0e3b03375b38b72
Author: godfreyhe <go...@163.com>
Date:   2017-08-03T03:01:04Z

    minor update

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4572: [Flink-7243] [connectors] Add ParquetInputFormat

Posted by godfreyhe <gi...@git.apache.org>.
Github user godfreyhe commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4572#discussion_r141783154
  
    --- Diff: flink-connectors/flink-parquet/pom.xml ---
    @@ -0,0 +1,81 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    +
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <groupId>org.apache.flink</groupId>
    +        <artifactId>flink-connectors</artifactId>
    +        <version>1.4-SNAPSHOT</version>
    +        <relativePath>..</relativePath>
    +    </parent>
    +
    +    <artifactId>flink-parquet_${scala.binary.version}</artifactId>
    +    <name>flink-parquet</name>
    +
    +    <packaging>jar</packaging>
    +
    +    <properties>
    +        <parquet.version>1.8.2</parquet.version>
    --- End diff --
    
    1.9.0 is ok 


---

[GitHub] flink issue #4572: [Flink-7243] [connectors] Add ParquetInputFormat

Posted by mustafaakin <gi...@git.apache.org>.
Github user mustafaakin commented on the issue:

    https://github.com/apache/flink/pull/4572
  
    Any inputs on this? Would be much useful and I can get rid of Drill / Presto


---

[GitHub] flink pull request #4572: [Flink-7243] [connectors] Add ParquetInputFormat

Posted by fpompermaier <gi...@git.apache.org>.
Github user fpompermaier commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4572#discussion_r139971451
  
    --- Diff: flink-connectors/flink-parquet/pom.xml ---
    @@ -0,0 +1,81 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    +
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <groupId>org.apache.flink</groupId>
    +        <artifactId>flink-connectors</artifactId>
    +        <version>1.4-SNAPSHOT</version>
    +        <relativePath>..</relativePath>
    +    </parent>
    +
    +    <artifactId>flink-parquet_${scala.binary.version}</artifactId>
    +    <name>flink-parquet</name>
    +
    +    <packaging>jar</packaging>
    +
    +    <properties>
    +        <parquet.version>1.8.2</parquet.version>
    --- End diff --
    
    Why not parquet 1.9.0? Is there any good reason for that?


---