[GitHub] [arrow] pitrou commented on a change in pull request #8050: ARROW-9852: [C++] Validate dictionaries fully when combining deltas

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #8050:
URL: https://github.com/apache/arrow/pull/8050#discussion_r481304054



##########
File path: cpp/src/arrow/ipc/reader.cc
##########
@@ -717,8 +717,10 @@ Status ReadDictionary(const Buffer& metadata, DictionaryMemo* dictionary_memo,
     return Status::Invalid("Dictionary record batch must only contain one field");
   }
   auto dictionary = batch->column(0);
-  // Validate the dictionary for safe delta concatenation
-  RETURN_NOT_OK(dictionary->Validate());
+  // Validate the dictionary for safe delta concatenation.  Full validation
+  // is necessary for certain types (for example nested dictionaries).
+  // XXX: instead only validate when a concatenation is actually done?
+  RETURN_NOT_OK(dictionary->ValidateFull());

Review comment:
       Ok, it is the strategy I have finally implemented.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org