You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/29 00:04:39 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #26761: Common sql bugfixes and improvements

uranusjr commented on code in PR #26761:
URL: https://github.com/apache/airflow/pull/26761#discussion_r982953375


##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -33,7 +33,21 @@
     from airflow.utils.context import Context
 
 
-def parse_boolean(val: str) -> str | bool:
+def _convert_to_float_if_possible(s):
+    """
+    A small helper function to convert a string to a numeric value

Review Comment:
   Type hints would however be a good idea here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org