You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2018/05/30 13:54:54 UTC
Review Request 67382: RANGER-2116: Ranger UI: Fix policy condition
field
usability issue when multi-line attribute is set to true in policy screen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67382/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2116
https://issues.apache.org/jira/browse/RANGER-2116
Repository: ranger
Description
-------
The current policy condition editor popup on Policy item in resource-based policies and tag-based policies is very difficult to use if you have complex conditions.
Also added syntax check button for the same.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a45bc8b
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 7af226f
security-admin/src/main/webapp/styles/xa.css 00809bc
Diff: https://reviews.apache.org/r/67382/diff/1/
Testing
-------
Tested :
1. User friendly and large Textarea coming for policy condition when multi-line attribute is set to true in service def for the policy condition.
2.Able to check syntax validation using `check syntax` button for the JS engine policy condition.
Thanks,
Nitin Galave
Re: Review Request 67382: RANGER-2116: Ranger UI: Fix policy
condition field
usability issue when multi-line attribute is set to true in policy screen
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67382/#review204101
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On May 30, 2018, 1:54 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67382/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 1:54 p.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2116
> https://issues.apache.org/jira/browse/RANGER-2116
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The current policy condition editor popup on Policy item in resource-based policies and tag-based policies is very difficult to use if you have complex conditions.
>
> Also added syntax check button for the same.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a45bc8b
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 7af226f
> security-admin/src/main/webapp/styles/xa.css 00809bc
>
>
> Diff: https://reviews.apache.org/r/67382/diff/1/
>
>
> Testing
> -------
>
> Tested :
> 1. User friendly and large Textarea coming for policy condition when multi-line attribute is set to true in service def for the policy condition.
> 2.Able to check syntax validation using `check syntax` button for the JS engine policy condition.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 67382: RANGER-2116: Ranger UI: Fix policy
condition field
usability issue when multi-line attribute is set to true in policy screen
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67382/#review204056
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On May 30, 2018, 1:54 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67382/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 1:54 p.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2116
> https://issues.apache.org/jira/browse/RANGER-2116
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The current policy condition editor popup on Policy item in resource-based policies and tag-based policies is very difficult to use if you have complex conditions.
>
> Also added syntax check button for the same.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js a45bc8b
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 7af226f
> security-admin/src/main/webapp/styles/xa.css 00809bc
>
>
> Diff: https://reviews.apache.org/r/67382/diff/1/
>
>
> Testing
> -------
>
> Tested :
> 1. User friendly and large Textarea coming for policy condition when multi-line attribute is set to true in service def for the policy condition.
> 2.Able to check syntax validation using `check syntax` button for the JS engine policy condition.
>
>
> Thanks,
>
> Nitin Galave
>
>