[jira] [Commented] (MAPREDUCE-4639) CombineFileInputFormat#getSplits should throw IOException when input paths contain a directory

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449501#comment-13449501 ] 

Hadoop QA commented on MAPREDUCE-4639:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12544000/MAPREDUCE-4639.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2821//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2821//console

This message is automatically generated.
                
> CombineFileInputFormat#getSplits should throw IOException when input paths contain a directory
> ----------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4639
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4639
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>            Reporter: Jim Donofrio
>            Priority: Minor
>         Attachments: MAPREDUCE-4639.patch
>
>
> FileInputFormat#getSplits throws an IOException when the input paths contain a directory. CombineFileInputFormat should do the same, otherwise the jo will not fail until the record reader is initialized when FileSystem#open will say that the directory does not exist.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira