[GitHub] [incubator-devlake-helm-chart] albinvass commented on pull request #130: Run devlake as a deployment instead of statefulset

["albinvass (via GitHub)" <gi...@apache.org>]

albinvass commented on PR #130:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/130#issuecomment-1559077111

   > Theoretically, the ENCODE_KEY can be generated by the user when deploying devlake, then we don't need the .env file at all. However, there are some concerns:
   
   I'm assuming the `ENCODE_KEY` is used to encrypt anything stored in the database? In that case losing the encode key could lead to loss of data. So in my opinion it's better if devlake requires a bit more work from the user than hiding a secret that can create issues for the user long-term. 
   
   I did a quick scan of the docs and can't find any mention of the encode key in the documentation, maybe I missed it? In any case I feel like the importance of the secret should be more pronounced, and the easiest way to do it is to fail on start if it's not available. The devlake executable could even have a command or tool to generate the secret for the user.
   https://devlake.apache.org/docs/Overview/Introduction
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org