[jira] [Resolved] (CALCITE-4075) Mock table 'EMPNULLABLES' should allow nulls in all non-pk columns

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stamatis Zampetakis resolved CALCITE-4075.
------------------------------------------
    Fix Version/s: 1.24.0
       Resolution: Fixed

Fixed in [c823343ef5ce1ffbef07a8c90cca8ed2e15678d9|https://github.com/apache/calcite/commit/c823343ef5ce1ffbef07a8c90cca8ed2e15678d9]. Thanks for the review [~danny0405]!

> Mock table 'EMPNULLABLES' should allow nulls in all non-pk columns
> ------------------------------------------------------------------
>
>                 Key: CALCITE-4075
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4075
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Trivial
>             Fix For: 1.24.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently Mock table 'EMPNULLABLES' allows nulls in almost every column. It does not allow nulls in the primary key which is expected and the column 'ENAME' that is unexpected.
> I realized that 'ENAME' column was declared as not nullable after debugging for quite some time a test where I was wrongly assuming that all columns of the table were nullable. 
> To avoid this kind of confusion in the future I propose to make 'ENAME' also nullable. The impact on existing tests is minimal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)