[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6855: Updated success message (curl and TP) for deleting a DS

[GitBox <gi...@apache.org>]

ocket8888 commented on code in PR #6855:
URL: https://github.com/apache/trafficcontrol/pull/6855#discussion_r881923038


##########
traffic_portal/test/integration/Data/deliveryservices.ts:
##########
@@ -357,17 +357,17 @@ export const deliveryservices = {
 				{
 					description: "delete a delivery service",
 					Name: "tpdservice1",
-					validationMessage: "Delivery service [ tpdservice1 ] deleted"
+					validationMessage: "Delivery service [ tpdservice1 ] deleted."

Review Comment:
   Do you think it's better with the period? I think a fair few of the Alerts we send from the API have punctuation, but also a lot don't. To be fair, the actual Alert TO sends has one.



##########
traffic_ops/traffic_ops_golang/api/shared_handlers.go:
##########
@@ -324,7 +324,13 @@ func DeleteHandler(deleter Deleter) http.HandlerFunc {
 		deleter,
 		HandleErr,
 		func(w http.ResponseWriter, r *http.Request, message string) {
-			WriteRespAlert(w, r, tc.SuccessLevel, message)
+			if deleter.GetType() == "ds" {
+				alerts := tc.CreateAlerts(tc.SuccessLevel, message)
+				alerts.AddNewAlert(tc.InfoLevel, "Perform a CDN snapshot then queue updates on all servers in the cdn for the changes to take affect.")

Review Comment:
   grammar: "affect" should be "effect"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org