You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/18 02:58:55 UTC
Review Request 63095: Added the Getting Started landing page.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
After moving the build documentation to its own page, we can now have a
real "Getting Started" page suitable for anyone to get started with
Mesos. It is purposefully short, and therefore not overwhelming.
Diffs
-----
site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
site/source/getting-started.html.md PRE-CREATION
site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
site/source/layouts/getting_started_section.erb PRE-CREATION
site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
Diff: https://reviews.apache.org/r/63095/diff/1/
Testing
-------
Built the site and tested it out locally.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/#review188460
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62548.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62548`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63095
Relevant logs:
- [apply-review-62548-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63095/logs/apply-review-62548-stdout.log):
```
error: patch failed: docs/home.md:96
error: docs/home.md: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 18, 2017, 2:58 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63095/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 2:58 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After moving the build documentation to its own page, we can now have a
> real "Getting Started" page suitable for anyone to get started with
> Mesos. It is purposefully short, and therefore not overwhelming.
>
>
> Diffs
> -----
>
> site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
> site/source/getting-started.html.md PRE-CREATION
> site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
> site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
> site/source/layouts/getting_started_section.erb PRE-CREATION
> site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
>
>
> Diff: https://reviews.apache.org/r/63095/diff/1/
>
>
> Testing
> -------
>
> Built the site and tested it out locally.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/#review188468
-----------------------------------------------------------
Fix it, then Ship it!
site/source/getting-started.html.md
Lines 19 (patched)
<https://reviews.apache.org/r/63095/#comment265479>
i would not link JIRA here for consistency.
- Vinod Kone
On Oct. 18, 2017, 2:58 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63095/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 2:58 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After moving the build documentation to its own page, we can now have a
> real "Getting Started" page suitable for anyone to get started with
> Mesos. It is purposefully short, and therefore not overwhelming.
>
>
> Diffs
> -----
>
> site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
> site/source/getting-started.html.md PRE-CREATION
> site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
> site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
> site/source/layouts/getting_started_section.erb PRE-CREATION
> site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
>
>
> Diff: https://reviews.apache.org/r/63095/diff/1/
>
>
> Testing
> -------
>
> Built the site and tested it out locally.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/#review188857
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Oct. 18, 2017, 6:46 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63095/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 6:46 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8117
> https://issues.apache.org/jira/browse/MESOS-8117
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After moving the build documentation to its own page, we can now have a
> real "Getting Started" page suitable for anyone to get started with
> Mesos. It is purposefully short, and therefore not overwhelming.
>
>
> Diffs
> -----
>
> site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
> site/source/getting-started.html.md PRE-CREATION
> site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
> site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
> site/source/layouts/getting_started_section.erb PRE-CREATION
> site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
>
>
> Diff: https://reviews.apache.org/r/63095/diff/2/
>
>
> Testing
> -------
>
> Built the site and tested it out locally.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/#review188622
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62548, 63093, 63095]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 18, 2017, 6:46 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63095/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 6:46 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After moving the build documentation to its own page, we can now have a
> real "Getting Started" page suitable for anyone to get started with
> Mesos. It is purposefully short, and therefore not overwhelming.
>
>
> Diffs
> -----
>
> site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
> site/source/getting-started.html.md PRE-CREATION
> site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
> site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
> site/source/layouts/getting_started_section.erb PRE-CREATION
> site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
>
>
> Diff: https://reviews.apache.org/r/63095/diff/2/
>
>
> Testing
> -------
>
> Built the site and tested it out locally.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/#review188591
-----------------------------------------------------------
PASS: Mesos patch 63095 was successfully built and tested.
Reviews applied: `['62548', '63093', '63095']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63095
- Mesos Reviewbot Windows
On Oct. 18, 2017, 11:46 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63095/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 11:46 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After moving the build documentation to its own page, we can now have a
> real "Getting Started" page suitable for anyone to get started with
> Mesos. It is purposefully short, and therefore not overwhelming.
>
>
> Diffs
> -----
>
> site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
> site/source/getting-started.html.md PRE-CREATION
> site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
> site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
> site/source/layouts/getting_started_section.erb PRE-CREATION
> site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
>
>
> Diff: https://reviews.apache.org/r/63095/diff/2/
>
>
> Testing
> -------
>
> Built the site and tested it out locally.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Oct. 29, 2017, 1:31 p.m., Tomasz Janiszewski wrote:
> > site/config.rb
> > Line 46 (original)
> > <https://reviews.apache.org/r/63095/diff/2/?file=1862582#file1862582line46>
> >
> > Why this line was removed?
> > We have an issue with breoken links on offical page https://issues.apache.org/jira/browse/MESOS-8145 and Google already idexed that link and it could be used on external sites such as StackOverflow. We should not break exisitng links – instead provide 301
Whoops, yeah I need to add a redirect. Will do Monday!
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/#review189526
-----------------------------------------------------------
On Oct. 18, 2017, 11:46 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63095/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 11:46 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8117
> https://issues.apache.org/jira/browse/MESOS-8117
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After moving the build documentation to its own page, we can now have a
> real "Getting Started" page suitable for anyone to get started with
> Mesos. It is purposefully short, and therefore not overwhelming.
>
>
> Diffs
> -----
>
> site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
> site/source/getting-started.html.md PRE-CREATION
> site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
> site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
> site/source/layouts/getting_started_section.erb PRE-CREATION
> site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
>
>
> Diff: https://reviews.apache.org/r/63095/diff/2/
>
>
> Testing
> -------
>
> Built the site and tested it out locally.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/#review189526
-----------------------------------------------------------
site/config.rb
Line 46 (original)
<https://reviews.apache.org/r/63095/#comment266642>
Why this line was removed?
We have an issue with breoken links on offical page https://issues.apache.org/jira/browse/MESOS-8145 and Google already idexed that link and it could be used on external sites such as StackOverflow. We should not break exisitng links – instead provide 301
- Tomasz Janiszewski
On Oct. 18, 2017, 6:46 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63095/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 6:46 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8117
> https://issues.apache.org/jira/browse/MESOS-8117
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After moving the build documentation to its own page, we can now have a
> real "Getting Started" page suitable for anyone to get started with
> Mesos. It is purposefully short, and therefore not overwhelming.
>
>
> Diffs
> -----
>
> site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
> site/source/getting-started.html.md PRE-CREATION
> site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
> site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
> site/source/layouts/getting_started_section.erb PRE-CREATION
> site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
>
>
> Diff: https://reviews.apache.org/r/63095/diff/2/
>
>
> Testing
> -------
>
> Built the site and tested it out locally.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 11:46 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Remove extra JIRA link.
Repository: mesos
Description
-------
After moving the build documentation to its own page, we can now have a
real "Getting Started" page suitable for anyone to get started with
Mesos. It is purposefully short, and therefore not overwhelming.
Diffs (updated)
-----
site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
site/source/getting-started.html.md PRE-CREATION
site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
site/source/layouts/getting_started_section.erb PRE-CREATION
site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
Diff: https://reviews.apache.org/r/63095/diff/2/
Changes: https://reviews.apache.org/r/63095/diff/1-2/
Testing
-------
Built the site and tested it out locally.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63095: Added the Getting Started landing page.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63095/#review188478
-----------------------------------------------------------
Bad patch!
Reviews applied: [63095, 63093, 62548]
Failed command: python support/apply-reviews.py -n -r 62548
Error:
2017-10-18 12:20:25 URL:https://reviews.apache.org/r/62548/diff/raw/ [29054/29054] -> "62548.patch" [1]
error: patch failed: docs/home.md:96
error: docs/home.md: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19831/console
- Mesos Reviewbot
On Oct. 18, 2017, 2:58 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63095/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 2:58 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After moving the build documentation to its own page, we can now have a
> real "Getting Started" page suitable for anyone to get started with
> Mesos. It is purposefully short, and therefore not overwhelming.
>
>
> Diffs
> -----
>
> site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7
> site/source/downloads.html.erb 3e24100a76a99b23ebc6589ee4f7332f43ef0ac9
> site/source/getting-started.html.md PRE-CREATION
> site/source/index.html.erb b4e847fadf6682503a4e09139491b539bc59e0fd
> site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66
> site/source/layouts/getting_started_section.erb PRE-CREATION
> site/source/layouts/layout.erb 9213c63e6fef3f57fc225a87a7d7e0abdcc11a88
>
>
> Diff: https://reviews.apache.org/r/63095/diff/1/
>
>
> Testing
> -------
>
> Built the site and tested it out locally.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>