You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/05 18:46:49 UTC
[GitHub] [geode] DonalEvans commented on a change in pull request #5978: GEODE-8894 allow individual deltas to trigger bucket size recalculation
DonalEvans commented on a change in pull request #5978:
URL: https://github.com/apache/geode/pull/5978#discussion_r571176732
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/DeltaForceSizingFlagDUnitTest.java
##########
@@ -0,0 +1,995 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.File;
+import java.io.IOException;
+import java.util.Random;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.DataSerializable;
+import org.apache.geode.DataSerializer;
+import org.apache.geode.cache.AttributesFactory;
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.DataPolicy;
+import org.apache.geode.cache.EntryEvent;
+import org.apache.geode.cache.EvictionAction;
+import org.apache.geode.cache.EvictionAttributes;
+import org.apache.geode.cache.InterestPolicy;
+import org.apache.geode.cache.PartitionAttributes;
+import org.apache.geode.cache.PartitionAttributesFactory;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.Scope;
+import org.apache.geode.cache.SubscriptionAttributes;
+import org.apache.geode.cache.control.ResourceManager;
+import org.apache.geode.cache.partition.PartitionRegionHelper;
+import org.apache.geode.cache.util.CacheListenerAdapter;
+import org.apache.geode.cache.util.ObjectSizer;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.test.dunit.Assert;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+
+/**
+ * Tests the use of the per-delta "forceRecalculateSize" flag.
+ */
+
+public class DeltaForceSizingFlagDUnitTest {
+
+ @Rule
+ public ClusterStartupRule cluster = new ClusterStartupRule();
+
+ protected MemberVM locator;
+ protected MemberVM server1;
+ protected MemberVM server2;
+
+ @Before
+ public void setup() {
+ int locatorPort;
+ locator = cluster.startLocatorVM(0);
+ locatorPort = locator.getPort();
+
+ server1 = cluster.startServerVM(1, locatorPort);
+ server2 = cluster.startServerVM(2, locatorPort);
+ }
+
+ @Test
+ public void testRRMemLRU() {
+ doRRMemLRUTest();
+ }
+
+ @Test
+ public void testRRMemLRUDeltaAndFlag() {
+ doRRMemLRUDeltaTest(true);
+ }
+
+ @Test
+ public void testRRMemLRUDelta() {
+ doRRMemLRUDeltaTest(false);
+ }
+
+ @Test
+ public void testRRListener() {
+ createRR(server1);
+ createRR(server2);
+
+ addListener(server1);
+ addListener(server2);
+
+ doListenerTestRR(server1.getVM(), server2.getVM());
+ }
+
+ @Test
+ public void testPRMemLRU() {
+ doPRMemLRUTest();
+ }
+
+ @Test
+ public void testPRMemLRUAndFlagDeltaPutOnPrimary() {
+ doPRDeltaTestLRU(false, false, true, false);
+ }
+
+ @Test
+ public void testPRMemLRUDeltaPutOnPrimary() {
+ doPRDeltaTestLRU(false, false, true, false);
+ }
+
+ @Test
+ public void testPRMemLRUAndFlagDeltaPutOnSecondary() {
+ doPRDeltaTestLRU(false, false, false, true);
+ }
+
+ @Test
+ public void testPRMemLRUDeltaPutOnSecondary() {
+ doPRDeltaTestLRU(false, false, false, true);
+ }
+
+ @Test
+ public void testPRNoLRUDelta() {
+ doPRNoLRUDeltaTest(false);
+ }
+
+ @Test
+ public void testPRNoLRUAndFlagDelta() {
+ doPRNoLRUDeltaTest(true);
+ }
+
+ @Test
+ public void testPRListener() {
+ createPR(server1, true);
+ createPR(server2, true);
+
+ addListener(server1);
+ addListener(server2);
+
+ doListenerTestPR(server1.getVM(), server2.getVM());
+ }
+
+ @Test
+ public void testPRHeapLRU() {
+ VM vm1 = server1.getVM();
+ VM vm2 = server2.getVM();
+
+ createPRHeapLRU(server1);
+ createPRHeapLRU(server2);
+
+ put(vm1, new TestKey("a"), new TestObject(100, 1000));
+
+ assertValueType(vm1, new TestKey("a"), ValueType.CD_SERIALIZED);
+ assertValueType(vm2, new TestKey("a"), ValueType.CD_SERIALIZED);
+
+ assertEquals(1, getObjectSizerInvocations(vm1));
+ long origSize0 = getSizeFromPRStats(vm1);
+ assertTrue("Size was " + origSize0, 1000 > origSize0);
+ assertEquals(1, getObjectSizerInvocations(vm2));
+ long origSize1 = getSizeFromPRStats(vm2);
+ assertTrue("Size was " + origSize1, 1000 > origSize1);
+
+ get(vm1, new TestKey("a"), new TestObject(100, 1000));
+
+ assertValueType(vm1, new TestKey("a"), ValueType.CD_DESERIALIZED);
+ assertValueType(vm2, new TestKey("a"), ValueType.CD_SERIALIZED);
+ assertEquals(3, getObjectSizerInvocations(vm1));
+ assertEquals(1, getObjectSizerInvocations(vm2));
+
+ // Test what happens when we reach the heap threshold??
+ }
+
+ @Test
+ public void testRRHeapLRU() {
+ VM vm1 = server1.getVM();
+ VM vm2 = server2.getVM();
+
+ createRRHeapLRU(server1);
+ createRRHeapLRU(server2);
+
+ put(vm1, "a", new TestObject(100, 1000));
+
+ assertValueType(vm1, "a", ValueType.RAW_VALUE);
+ assertValueType(vm2, "a", ValueType.CD_SERIALIZED);
+
+ assertEquals(1, getObjectSizerInvocations(vm1));
+ assertEquals(0, getObjectSizerInvocations(vm2));
+
+ get(vm2, "a", new TestObject(100, 1000));
+
+ assertValueType(vm1, "a", ValueType.RAW_VALUE);
+ assertValueType(vm2, "a", ValueType.CD_DESERIALIZED);
+ assertEquals(1, getObjectSizerInvocations(vm1));
+ assertEquals(1, getObjectSizerInvocations(vm2));
+
+ // Test what happens when we reach the heap threshold??
+ }
+
+ @Test
+ public void testPRHeapLRUDeltaWithFlagPutOnPrimary() {
+ doPRDeltaTestLRU(false, true, true, false);
+ }
+
+ @Test
+ public void testPRHeapLRUDeltaPutOnPrimary() {
+ doPRDeltaTestLRU(false, true, true, false);
+ }
+
+ @Test
+ public void testPRHeapLRUDeltaWithFlagPutOnSecondary() {
+ doPRDeltaTestLRU(false, true, false, true);
+ }
+
+ @Test
+ public void testPRHeapLRUDeltaPutOnSecondary() {
+ doPRDeltaTestLRU(false, true, false, true);
+ }
+
+ // test to cover bug41916
+ @Test
+ public void testLargeDelta() {
+ VM vm1 = server1.getVM();
+ VM vm2 = server2.getVM();
+
+ createPR(server1, false);
+ createPR(server2, false);
+ // make a string bigger than socket-buffer-size which defaults to 32k
+ int BIG_DELTA_SIZE = 32 * 1024 * 2;
+ StringBuilder sb = new StringBuilder(BIG_DELTA_SIZE);
+ for (int i = 0; i < BIG_DELTA_SIZE; i++) {
+ sb.append('7');
+ }
+ TestDelta delta1 = new TestDelta(true, sb.toString());
+
+ assignPRBuckets(server1);
+ boolean vm0isPrimary = prHostsBucketForKey(server1, 0);
+ if (!vm0isPrimary) {
+ assertEquals(true, prHostsBucketForKey(server2, 0));
+ }
+ VM secondaryVm;
+ if (vm0isPrimary) {
+ secondaryVm = vm2;
+ } else {
+ secondaryVm = vm1;
+ }
+
+ put(secondaryVm, 0, delta1);
+ }
+
+ void doPRDeltaTestLRU(boolean shouldSizeChange, boolean heapLRU, boolean putOnPrimary,
+ boolean wasDelta) {
+ VM vm1 = server1.getVM();
+ VM vm2 = server2.getVM();
+
+ if (heapLRU) {
+ createPRHeapLRU(server1);
+ createPRHeapLRU(server2);
+ } else {// memLRU
+ createPR(server1, true);
+ createPR(server2, true);
+ }
+ assignPRBuckets(server1);
+ boolean vm0isPrimary = prHostsBucketForKey(server1, 0);
+ if (!vm0isPrimary) {
+ assertEquals(true, prHostsBucketForKey(server2, 0));
+ }
+ VM primaryVm;
+ VM secondaryVm;
+ if (vm0isPrimary) {
+ primaryVm = vm1;
+ secondaryVm = vm2;
+ } else {
+ primaryVm = vm2;
+ secondaryVm = vm1;
+ }
+
+ TestDelta delta1 = new TestDelta(false, "12345", shouldSizeChange);
+ if (putOnPrimary) {
+ put(primaryVm, 0, delta1);
+ } else {
+ put(secondaryVm, 0, delta1);
+ }
+ // if the put is done on the primary then it will be CD_DESERIALIZED on the primary
+ // otherwise it will be CD_SERIALIZED on the primary.
+ if (putOnPrimary) {
+ assertValueType(primaryVm, 0, ValueType.CD_DESERIALIZED);
+ assertEquals(1, getObjectSizerInvocations(primaryVm));
+ } else {
+ assertValueType(primaryVm, 0, ValueType.CD_SERIALIZED);
+ assertEquals(0, getObjectSizerInvocations(primaryVm));
+ }
+ // It will always be CD_SERIALIZED on the secondary.
+ assertValueType(secondaryVm, 0, ValueType.CD_SERIALIZED);
+ assertEquals(0, getObjectSizerInvocations(secondaryVm));
+
+ long origEvictionSize0 = getSizeFromEvictionStats(primaryVm);
+ long origEvictionSize1 = getSizeFromEvictionStats(secondaryVm);
+ long origPRSize0 = getSizeFromPRStats(primaryVm);
+ long origPRSize1 = getSizeFromPRStats(secondaryVm);
+ delta1.info = "1234567890";
+ delta1.hasDelta = true;
+ // Update the delta
+ if (putOnPrimary) {
+ put(primaryVm, 0, delta1);
+ } else {
+ put(secondaryVm, 0, delta1);
+ }
+
+ assertValueType(primaryVm, 0, ValueType.CD_DESERIALIZED);
+ assertValueType(secondaryVm, 0, ValueType.CD_DESERIALIZED);
+
+ if (shouldSizeChange) {
+ assertEquals(2, getObjectSizerInvocations(primaryVm));
+ // once when we deserialize the value in the cache
+ // and once when we size the new value from applying the delta
+ assertEquals(2, getObjectSizerInvocations(secondaryVm));
+ } else if (wasDelta) {
+ assertEquals(0, getObjectSizerInvocations(primaryVm));
+ // 1 sizer invoke since the first value needs to be deserialized
+ assertEquals(0, getObjectSizerInvocations(secondaryVm));
+ } else {
+ assertEquals(1, getObjectSizerInvocations(primaryVm));
+ // 1 sizer invoke since the first value needs to be deserialized
+ assertEquals(0, getObjectSizerInvocations(secondaryVm));
+ }
+
+ long finalEvictionSize0 = getSizeFromEvictionStats(primaryVm);
+ long finalEvictionSize1 = getSizeFromEvictionStats(secondaryVm);
+ long finalPRSize0 = getSizeFromPRStats(primaryVm);
+ long finalPRSize1 = getSizeFromPRStats(secondaryVm);
+ if (shouldSizeChange) {
+ // I'm not sure what the change in size should be, because we went
+ // from serialized to deserialized
+ assertTrue(finalEvictionSize0 - origEvictionSize0 != 0);
+ assertTrue(finalPRSize0 - origPRSize0 != 0);
+ assertTrue(finalEvictionSize1 - origEvictionSize1 != 0);
+ assertTrue(finalPRSize1 - origPRSize1 != 0);
+ } else {
+ assertEquals(0, finalEvictionSize1 - origEvictionSize1);
+ assertEquals(0, finalPRSize0 - origPRSize0);
+ assertEquals(0, finalPRSize1 - origPRSize1);
+ }
+ }
+
+ private void addListener(MemberVM memberVM) {
+ memberVM.invoke("Add listener", () -> {
+ Cache cache = ClusterStartupRule.getCache();
+ Region region = cache.getRegion("region");
+ try {
+ region.getAttributesMutator().addCacheListener(new TestCacheListener());
+ } catch (Exception e) {
+ Assert.fail("couldn't create index", e);
+ }
+ });
+ }
+
+
+ private void doListenerTestRR(VM vm0, VM vm1) {
+ assertEquals(0, getObjectSizerInvocations(vm0));
+ assertEquals(0, getObjectSizerInvocations(vm1));
+ put(vm0, "a", new TestObject(100, 100000));
+ assertEquals(1, getObjectSizerInvocations(vm0));
+ assertEquals(1, getObjectSizerInvocations(vm1));
+
+ long origEvictionSize0 = getSizeFromEvictionStats(vm0);
+ long origEvictionSize1 = getSizeFromEvictionStats(vm1);
+
+ assertValueType(vm0, "a", ValueType.RAW_VALUE);
+ assertValueType(vm1, "a", ValueType.CD_DESERIALIZED);
+ assertTrue(origEvictionSize0 >= 100000);
+ assertTrue(origEvictionSize1 >= 100000);
+
+ put(vm0, "a", new TestObject(200, 200000));
+ assertEquals(2, getObjectSizerInvocations(vm0));
+ assertEquals(2, getObjectSizerInvocations(vm1));
+
+ long finalEvictionSize0 = getSizeFromEvictionStats(vm0);
+ long finalEvictionSize1 = getSizeFromEvictionStats(vm1);
+
+ assertValueType(vm0, "a", ValueType.RAW_VALUE);
+ assertValueType(vm1, "a", ValueType.CD_DESERIALIZED);
+ assertEquals(100000, finalEvictionSize0 - origEvictionSize0);
+ assertEquals(100000, finalEvictionSize1 - origEvictionSize1);
+ }
+
+ private void doListenerTestPR(VM vm0, VM vm1) {
+ assertEquals(0, getObjectSizerInvocations(vm0));
+ assertEquals(0, getObjectSizerInvocations(vm1));
+ put(vm0, "a", new TestObject(100, 100000));
+ assertEquals(1, getObjectSizerInvocations(vm0));
+ assertEquals(1, getObjectSizerInvocations(vm1));
+
+ long origEvictionSize0 = getSizeFromEvictionStats(vm0);
+ long origEvictionSize1 = getSizeFromEvictionStats(vm1);
+ long origPRSize0 = getSizeFromPRStats(vm1);
+ long origPRSize1 = getSizeFromPRStats(vm1);
+
+ assertValueType(vm0, "a", ValueType.CD_DESERIALIZED);
+ assertValueType(vm1, "a", ValueType.CD_DESERIALIZED);
+ assertTrue(origEvictionSize1 >= 100000);
+ assertTrue(origEvictionSize0 >= 100000);
+ assertTrue(origPRSize0 <= 500);
+ assertTrue(origPRSize1 <= 500);
+
+ put(vm0, "a", new TestObject(200, 200000));
+ assertEquals(2, getObjectSizerInvocations(vm0));
+ assertEquals(2, getObjectSizerInvocations(vm1));
+
+ long finalEvictionSize0 = getSizeFromEvictionStats(vm0);
+ long finalEvictionSize1 = getSizeFromEvictionStats(vm1);
+ long finalPRSize0 = getSizeFromPRStats(vm0);
+ long finalPRSize1 = getSizeFromPRStats(vm1);
+
+ assertValueType(vm0, "a", ValueType.CD_DESERIALIZED);
+ assertValueType(vm1, "a", ValueType.CD_DESERIALIZED);
+ assertEquals(100000, finalEvictionSize0 - origEvictionSize0);
+ assertEquals(100000, finalEvictionSize1 - origEvictionSize1);
+ assertEquals(100, finalPRSize0 - origPRSize0);
+ assertEquals(100, finalPRSize1 - origPRSize1);
+ }
+
+
+ private void doRRMemLRUTest() {
+ VM vm1 = server1.getVM();
+ VM vm2 = server2.getVM();
+
+ createRR(server1);
+ createRR(server2);
+ put(vm1, "a", new TestObject(100, 100000));
+ long origEvictionSize0 = getSizeFromEvictionStats(vm1);
+ long origEvictionSize1 = getSizeFromEvictionStats(vm2);
+ put(vm1, "a", new TestObject(200, 200000));
+
+ assertValueType(vm1, "a", ValueType.RAW_VALUE);
+ assertValueType(vm2, "a", ValueType.CD_SERIALIZED);
+ assertEquals(2, getObjectSizerInvocations(vm1));
+
+ long finalEvictionSize0 = getSizeFromEvictionStats(vm1);
+ long finalEvictionSize1 = getSizeFromEvictionStats(vm2);
+ assertEquals(100000, finalEvictionSize0 - origEvictionSize0);
+ assertEquals(100, finalEvictionSize1 - origEvictionSize1);
+
+ assertEquals(0, getObjectSizerInvocations(vm2));
+
+ // Do a get to make sure we deserialize the object and calculate
+ // the size adjustment
+ Object v = new TestObject(200, 200000);
+ get(vm2, "a", v);
+ int vSize = CachedDeserializableFactory.calcSerializedMemSize(v);
+
+ assertValueType(vm2, "a", ValueType.CD_DESERIALIZED);
+ long evictionSizeAfterGet = getSizeFromEvictionStats(vm2);
+ assertEquals(1, getObjectSizerInvocations(vm2));
+ assertEquals(200000 + CachedDeserializableFactory.overhead() - vSize,
+ evictionSizeAfterGet - finalEvictionSize1);
+
+ // Do a put that will trigger an eviction if it is deserialized
+ put(vm1, "b", new TestObject(100, 1000000));
+
+ assertEquals(1, getEvictions(vm1));
+ assertEquals(0, getEvictions(vm2));
+
+ // Do a get to make sure we deserialize the object and calculate
+ // the size adjustment
+ get(vm2, "b", new TestObject(100, 1000000));
+ assertEquals(1, getEvictions(vm2));
+ }
+
+ private void doPRMemLRUTest() {
+ VM vm1 = server1.getVM();
+ VM vm2 = server2.getVM();
+
+ createPR(server1, true);
+ createPR(server2, true);
+
+ put(vm1, 0, new TestObject(100, 100000));
+ assertValueType(vm1, 0, ValueType.CD_SERIALIZED);
+ assertValueType(vm2, 0, ValueType.CD_SERIALIZED);
+ long origEvictionSize0 = getSizeFromEvictionStats(vm1);
+ long origEvictionSize1 = getSizeFromEvictionStats(vm2);
+ long origPRSize0 = getSizeFromPRStats(vm1);
+ long origPRSize1 = getSizeFromPRStats(vm2);
+ put(vm1, 0, new TestObject(200, 200000));
+
+ assertEquals(0, getObjectSizerInvocations(vm1));
+
+ long finalEvictionSize0 = getSizeFromEvictionStats(vm1);
+ long finalPRSize0 = getSizeFromPRStats(vm1);
+ long finalEvictionSize1 = getSizeFromEvictionStats(vm2);
+ long finalPRSize1 = getSizeFromPRStats(vm2);
+ assertEquals(100, finalEvictionSize0 - origEvictionSize0);
+ assertEquals(100, finalEvictionSize1 - origEvictionSize1);
+ assertEquals(100, finalPRSize0 - origPRSize0);
+ assertEquals(100, finalPRSize1 - origPRSize1);
+
+ assertEquals(0, getObjectSizerInvocations(vm2));
+
+ // Do a get to see if we deserialize the object and calculate
+ // the size adjustment
+ Object v = new TestObject(200, 200000);
+ get(vm1, 0, v);
+ int vSize = CachedDeserializableFactory.calcSerializedMemSize(v);
+ assertValueType(vm1, 0, ValueType.CD_DESERIALIZED);
+ assertValueType(vm2, 0, ValueType.CD_SERIALIZED);
+ long evictionSizeAfterGet = getSizeFromEvictionStats(vm1);
+ long prSizeAfterGet = getSizeFromPRStats(vm1);
+ assertEquals(1, getObjectSizerInvocations(vm1));
+ assertEquals(0, getObjectSizerInvocations(vm2));
+ assertEquals(200000 + CachedDeserializableFactory.overhead() - vSize,
+ evictionSizeAfterGet - finalEvictionSize0);
+ assertEquals(0, prSizeAfterGet - finalPRSize0);
+
+ // Do a put that will trigger an eviction if it is deserialized
+ // It should not be deserialized.
+ put(vm1, 113, new TestObject(100, 1024 * 1024));
+ assertValueType(vm1, 113, ValueType.CD_SERIALIZED);
+ assertValueType(vm2, 113, ValueType.CD_SERIALIZED);
+ long evictionSizeAfterPutVm1 = getSizeFromEvictionStats(vm2);
+
+ assertEquals(0, getEvictions(vm1));
+ assertEquals(0, getEvictions(vm2));
+
+ // Do a get to make sure we deserialize the object and calculate
+ // the size adjustment which should force an eviction
+ get(vm2, 113, new TestObject(100, 1024 * 1024));
+ long evictionSizeAfterGetVm1 = getSizeFromEvictionStats(vm2);
+ assertValueType(vm1, 113, ValueType.CD_SERIALIZED);
+ assertValueType(vm2, 113, ValueType.EVICTED);
+ assertEquals(1, getObjectSizerInvocations(vm1)); // from the get of key 0 on vm0
+ assertEquals(0, getEvictions(vm1));
+ assertEquals(1, getObjectSizerInvocations(vm2));
+ assertEquals(2, getEvictions(vm2));
+ }
+
+ private void doRRMemLRUDeltaTest(boolean shouldSizeChange) {
+ VM vm1 = server1.getVM();
+ VM vm2 = server2.getVM();
+
+ createRR(server1);
+ createRR(server2);
+ TestDelta delta1 = new TestDelta(false, "12345", shouldSizeChange);
+ put(vm1, "a", delta1);
+
+ assertValueType(vm1, "a", ValueType.RAW_VALUE);
+ assertValueType(vm2, "a", ValueType.CD_SERIALIZED);
+ assertEquals(1, getObjectSizerInvocations(vm1));
+ assertEquals(0, getObjectSizerInvocations(vm2));
+
+ long origEvictionSize0 = getSizeFromEvictionStats(vm1);
+ long origEvictionSize1 = getSizeFromEvictionStats(vm2);
+ delta1.info = "1234567890";
+ delta1.hasDelta = true;
+ // Update the delta
+ put(vm1, "a", delta1);
+
+ assertValueType(vm1, "a", ValueType.RAW_VALUE);
+ assertValueType(vm2, "a", ValueType.CD_DESERIALIZED);
+
+ assertEquals(2, getObjectSizerInvocations(vm1));
+
+ long finalEvictionSize0 = getSizeFromEvictionStats(vm1);
+ long finalEvictionSize1 = getSizeFromEvictionStats(vm2);
+ assertEquals(5, finalEvictionSize0 - origEvictionSize0);
+ if (shouldSizeChange) {
+ assertEquals(1, getObjectSizerInvocations(vm2));
+ // I'm not sure what the change in size should be, because we went
+ // from serialized to deserialized
+ assertTrue(finalEvictionSize1 - origEvictionSize1 != 0);
+ } else {
+ // we invoke the sizer once when we deserialize the original to apply the delta to it
+ assertEquals(0, getObjectSizerInvocations(vm2));
+ assertEquals(0, finalEvictionSize1 - origEvictionSize1);
+ }
+ }
+
+ private void doPRNoLRUDeltaTest(boolean shouldSizeChange) {
+ VM vm1 = server1.getVM();
+ VM vm2 = server2.getVM();
+
+ createPR(server1, false);
+ createPR(server2, false);
+
+ TestDelta delta1 = new TestDelta(false, "12345", shouldSizeChange);
+ put(vm1, "a", delta1);
+ long origPRSize0 = getSizeFromPRStats(vm1);
+ long origPRSize1 = getSizeFromPRStats(vm2);
+
+ // Update the delta
+ delta1.info = "1234567890";
+ delta1.hasDelta = true;
+ put(vm1, "a", delta1);
+ long finalPRSize0 = getSizeFromPRStats(vm1);
+ long finalPRSize1 = getSizeFromPRStats(vm2);
+
+ if (shouldSizeChange) {
+ // I'm not sure what the change in size should be, because we went
+ // from serialized to deserialized
+ assertTrue(finalPRSize0 - origPRSize0 != 0);
+ assertTrue(finalPRSize1 - origPRSize1 != 0);
+ } else {
+ assertEquals(0, finalPRSize0 - origPRSize0);
+ assertEquals(0, finalPRSize1 - origPRSize1);
+ }
+ }
+
+ private long getSizeFromPRStats(VM vm0) {
+ return (Long) vm0.invoke("getSizeFromPRStats", () -> {
+ Cache cache = ClusterStartupRule.getCache();
+ LocalRegion region = (LocalRegion) cache.getRegion("region");
+ if (region instanceof PartitionedRegion) {
+ long total = 0;
+ PartitionedRegion pr = ((PartitionedRegion) region);
+ for (int i = 0; i < pr.getPartitionAttributes().getTotalNumBuckets(); i++) {
+ total += pr.getDataStore().getBucketSize(i);
+ }
+ return total;
+ } else {
+ return 0L;
+ }
+ });
+ }
+
+ private long getSizeFromEvictionStats(VM vm0) {
+ return (Long) vm0.invoke("getSizeFromEvictionStats", () -> {
+
+ Cache cache = ClusterStartupRule.getCache();
+ LocalRegion region = (LocalRegion) cache.getRegion("region");
+ return getSizeFromEvictionStats(region);
Review comment:
In this case, the `getSizeFromEvictionStats(region)` method is so small that this line be replaced by simply `return region.getEvictionCounter();`. Adding a method to the test class just for this one call seems to be adding unnecessary complexity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org