You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/28 07:22:06 UTC
[GitHub] [netbeans] jlahoda opened a new pull request #2785: Java chained types improvement feb 2020
jlahoda opened a new pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785
As noted here:
https://github.com/apache/netbeans/pull/2365#issuecomment-763579047
When the Java editor shows return types for chained method invocations, it could possibly show them in additional contexts. This PR is trying to show the return types in most/all contexts.
Feedback/opinions are welcome!
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-946620568
@matthiasblaesing @jlahoda thoughts on this? Doesn't seem fully resolved, but don't want to keep pushing back milestones. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-886393341
@ebarboni - I think the existing state is acceptable, so this should only be merged when we are satisfied with the result. I apologize I didn't have time to look through Matthias' comments yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-886722123
ok moving to 12.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-796983561
I think this is a nice update to the parameter name annotations. I'm not sure, whether I prefer the types at the end or if it would be easier to follow if the return types would be showed inline between the braces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-821506520
Sorry for the late reply. I had another look at this tonight and found some issues:
It looks as if the return type output only works once:
For the second prototype, I like the inline display, but the alignment looks strange (left Marker) and it seems the intermediate returns displayed in the first prototype (above) are missing here (right marker):
Thinking over this, having the types at the end of the line has less impact on the layout, though the parameters already take size.
One thing I noticed with the cursor handling is, that it now feels a bit strange with the types:
At this point I'd have expected the cursor behind the closing brace, not behind the type. Just an idea: place the cursor on the side of the type/parameter signature, that has no whitespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-810541353
@geertjanw - I think the main task here is to decide which of the variants we want to follow (or if there is a different variant we want to follow). The code is hopefully more or less fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-885695089
@matthiasblaesing @jlahoda, can we merge this. And later make UI improvement or the current is not usable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-803270118
Thanks for the comment, @matthiasblaesing . I've tried to sketch putting the inline types after the braces (which, I think, also allows to eliminate some that are probably not so interesting, as they are not part of chained method invocation). I've put that here:
https://github.com/jlahoda/netbeans/tree/java-chained-types-improvement-feb-2020-var2
A sample screenshot:
What do you think?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-1021301631
eagerly waiting for the feb 2022 version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-820927431
Let's wait, I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] netbeansuser2019 commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
netbeansuser2019 commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-899242281
Nothing against that inline hints, but sometimes it takes to much space on screen so need scrolling.
Maybe one more suggestion if it could not be possible to be added one extra option to view menu to show only on active e.g. when (typing) cursor is in "chained tree" and mouse is over it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-1013035781
As there's been no follow up and this has been bumped a number of milestones already, I'm just going to remove the milestone. Please close, update or re-add to a milestone if discussion is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-1021301631
eagerly waiting for the feb 2022 version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-820460331
Should this go in for 12.4 or should we delay for 12.5? I.e., @jlahoda, feel free to make a choice above and just let's go with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on pull request #2785: Java chained types improvement feb 2020
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2785:
URL: https://github.com/apache/netbeans/pull/2785#issuecomment-809734674
How ready is this for 12.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists