You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andy Pang <pa...@huawei.com> on 2017/04/20 09:35:53 UTC
Review Request 58557: Print failure reason when socket accept failed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58557/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
Description
-------
Print failure reason when socket accept failed.
Diffs
-----
3rdparty/libprocess/src/process.cpp 92efa91
Diff: https://reviews.apache.org/r/58557/diff/1/
Testing
-------
make check
Thanks,
Andy Pang
Re: Review Request 58557: Print failure reason when socket accept
failed.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58557/#review172875
-----------------------------------------------------------
3rdparty/libprocess/src/process.cpp
Lines 950-951 (original), 950-954 (patched)
<https://reviews.apache.org/r/58557/#comment245889>
how about
```
} else {
LOG(ERROR) << "Failed to accept socket: "
<< (socket.isFailed() ? socket.failure() : "future discarded");
}
```
- Vinod Kone
On April 20, 2017, 9:35 a.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58557/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 9:35 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print failure reason when socket accept failed.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 92efa91
>
>
> Diff: https://reviews.apache.org/r/58557/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>
Re: Review Request 58557: Print failure reason when socket accept
failed.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58557/#review172911
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58557]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 25, 2017, 1:14 a.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58557/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 1:14 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print failure reason when socket accept failed.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 92efa91
>
>
> Diff: https://reviews.apache.org/r/58557/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>
Re: Review Request 58557: Print failure reason when socket accept
failed.
Posted by Andy Pang <pa...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58557/
-----------------------------------------------------------
(Updated \u56db\u6708 25, 2017, 1:14 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
Description
-------
Print failure reason when socket accept failed.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 92efa91
Diff: https://reviews.apache.org/r/58557/diff/2/
Changes: https://reviews.apache.org/r/58557/diff/1-2/
Testing
-------
make check
Thanks,
Andy Pang
Re: Review Request 58557: Print failure reason when socket accept
failed.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58557/#review172474
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58557]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 20, 2017, 9:35 a.m., Andy Pang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58557/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 9:35 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Print failure reason when socket accept failed.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 92efa91
>
>
> Diff: https://reviews.apache.org/r/58557/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andy Pang
>
>