[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

[GitBox <gi...@apache.org>]

aooohan commented on code in PR #36:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1004088967


##########
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##########
@@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes, EESpecProfile profile) {
         if (attributes.containsKey(Attributes.Name.IMPLEMENTATION_VERSION)) {
             String newValue = attributes.get(Attributes.Name.IMPLEMENTATION_VERSION) + "-" + Info.getVersion();
             attributes.put(Attributes.Name.IMPLEMENTATION_VERSION, newValue);
-            result = true;
+            // Purposefully avoid setting result

Review Comment:
   Changing the version also counts as a conversion, so here need to revert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org