You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrew Morrison (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 21:54:37 UTC
[jira] [Created] (LUCENE-3875) ValueSourceFilter
ValueSourceFilter
-----------------
Key: LUCENE-3875
URL: https://issues.apache.org/jira/browse/LUCENE-3875
Project: Lucene - Java
Issue Type: New Feature
Reporter: Andrew Morrison
Attachments: LUCENE-3875.patch
A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3875) ValueSourceFilter
Posted by "Andrew Morrison (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Morrison updated LUCENE-3875:
------------------------------------
Attachment: LUCENE-3875.patch
> ValueSourceFilter
> -----------------
>
> Key: LUCENE-3875
> URL: https://issues.apache.org/jira/browse/LUCENE-3875
> Project: Lucene - Java
> Issue Type: New Feature
> Reporter: Andrew Morrison
> Attachments: LUCENE-3875.patch
>
>
> A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
> We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3875) ValueSourceFilter
Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245980#comment-13245980 ]
Chris Male commented on LUCENE-3875:
------------------------------------
Hey Gregg,
Did a quick review and it looks great. I'm happy to commit this when its ready.
The general trend is to use FixedBitSet instead of OpenBitSet in situations like this where we know the maximum size. Could you make the change? Also in the tests, could we move the createIndex and destroyIndex into setUp() and tearDown() respectively?
> ValueSourceFilter
> -----------------
>
> Key: LUCENE-3875
> URL: https://issues.apache.org/jira/browse/LUCENE-3875
> Project: Lucene - Java
> Issue Type: New Feature
> Reporter: Andrew Morrison
> Attachments: LUCENE-3875-1.patch, LUCENE-3875.patch
>
>
> A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
> We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3875) ValueSourceFilter
Posted by "Andrew Morrison (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247214#comment-13247214 ]
Andrew Morrison commented on LUCENE-3875:
-----------------------------------------
Ha! ValueSourceRangeFilter does the job. This patch shouldn't be committed. Thanks!
> ValueSourceFilter
> -----------------
>
> Key: LUCENE-3875
> URL: https://issues.apache.org/jira/browse/LUCENE-3875
> Project: Lucene - Java
> Issue Type: New Feature
> Reporter: Andrew Morrison
> Attachments: LUCENE-3875-1.patch, LUCENE-3875.patch, LUCENE-3875.patch
>
>
> A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
> We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3875) ValueSourceFilter
Posted by "Andrew Morrison (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Morrison updated LUCENE-3875:
------------------------------------
Attachment: LUCENE-3875.patch
Thanks, Chris.
The latest patch uses a FixedBitSet and cleans up the tests a bit.
> ValueSourceFilter
> -----------------
>
> Key: LUCENE-3875
> URL: https://issues.apache.org/jira/browse/LUCENE-3875
> Project: Lucene - Java
> Issue Type: New Feature
> Reporter: Andrew Morrison
> Attachments: LUCENE-3875-1.patch, LUCENE-3875.patch, LUCENE-3875.patch
>
>
> A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
> We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Closed] (LUCENE-3875) ValueSourceFilter
Posted by "Andrew Morrison (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Morrison closed LUCENE-3875.
-----------------------------------
Resolution: Won't Fix
Closing because this patch duplicates a subset of the behavior of ValueSourceRangeFilter.
> ValueSourceFilter
> -----------------
>
> Key: LUCENE-3875
> URL: https://issues.apache.org/jira/browse/LUCENE-3875
> Project: Lucene - Java
> Issue Type: New Feature
> Reporter: Andrew Morrison
> Attachments: LUCENE-3875-1.patch, LUCENE-3875.patch, LUCENE-3875.patch
>
>
> A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
> We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3875) ValueSourceFilter
Posted by "Gregg Donovan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregg Donovan updated LUCENE-3875:
----------------------------------
Attachment: LUCENE-3875-1.patch
Patch updated to use OpenBitSet and implement better hashCode and equals methods.
> ValueSourceFilter
> -----------------
>
> Key: LUCENE-3875
> URL: https://issues.apache.org/jira/browse/LUCENE-3875
> Project: Lucene - Java
> Issue Type: New Feature
> Reporter: Andrew Morrison
> Attachments: LUCENE-3875-1.patch, LUCENE-3875.patch
>
>
> A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
> We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3875) ValueSourceFilter
Posted by "Chris Male (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247025#comment-13247025 ]
Chris Male commented on LUCENE-3875:
------------------------------------
Hey Andrew,
I was actually thinking about this a little more, wondering about adding full range support when I realised that Solr already supports this through {{org.apache.solr.search.function.ValueSourceRangeFilter}}. Does that meet your needs or is there a usecase it doesn't fulfil that the patch here does?
> ValueSourceFilter
> -----------------
>
> Key: LUCENE-3875
> URL: https://issues.apache.org/jira/browse/LUCENE-3875
> Project: Lucene - Java
> Issue Type: New Feature
> Reporter: Andrew Morrison
> Attachments: LUCENE-3875-1.patch, LUCENE-3875.patch, LUCENE-3875.patch
>
>
> A ValueSourceFilter is a filter that takes a ValueSource and a threshold value, filtering out documents for which their value returned by the ValueSource is below the threshold.
> We use the ValueSourceFilter for filtering documents based on their value in an ExternalFileField.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org