[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37955: [SPARK-40512][SPARK-40896][PS][INFRA] Upgrade pandas to 1.5.0

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #37955:
URL: https://github.com/apache/spark/pull/37955#discussion_r1005545832


##########
python/pyspark/pandas/strings.py:
##########
@@ -2316,7 +2316,7 @@ def zfill(self, width: int) -> "ps.Series":
         left). 1000 remains unchanged as it is longer than width.
 
         >>> s.str.zfill(3)
-        0     0-1
+        0     -01

Review Comment:
   Can we skip this docetsts so the tsets can pass with lower pandas versions too?



##########
python/pyspark/pandas/indexes/datetimes.py:
##########
@@ -285,7 +285,7 @@ def is_month_start(self) -> Index:
         --------
         >>> idx = ps.date_range("2018-02-27", periods=3)
         >>> idx.is_month_start
-        Index([False, False, True], dtype='object')
+        Index([False, False, True], dtype='bool')

Review Comment:
   ditto



##########
python/pyspark/pandas/base.py:
##########
@@ -954,7 +954,7 @@ def notnull(self: IndexOpsLike) -> IndexOpsLike:
         dtype: bool
 
         >>> ser.rename("a").to_frame().set_index("a").index.notna()
-        Index([True, True, False], dtype='object', name='a')
+        Index([True, True, False], dtype='bool', name='a')

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org