[PR] fix(salesforce): read OSSIE_SQL_2026 metric expressions [ossie]

["RyutoYoda (via GitHub)" <gi...@apache.org>]

RyutoYoda opened a new pull request, #513:
URL: https://github.com/apache/ossie/pull/513

   ## Summary
   
   #439 added `OSSIE_SQL_2026` to the core spec. The Salesforce converter never learned
   it: `MetricExpressionTranslator.DIALECTS` lists only `TABLEAU`, `SNOWFLAKE` and
   `ANSI_SQL`, so a metric written in the portable dialect aborts the whole conversion
   rather than being dropped — on `main`, this model produces no output file at all and
   the valid `TABLEAU` metric next to it is lost too:
   
   ```
   Error: Metric 'portable_only': no supported dialect; provide TABLEAU, SNOWFLAKE or ANSI_SQL
   exit 3
   ```
   
   `OSSIE_SQL_2026` is ANSI-SQL-based, so it joins the chain last — `TABLEAU`,
   `SNOWFLAKE`, `ANSI_SQL`, `OSSIE_SQL_2026` — and a vendor dialect still wins when both
   are present. It then parses on exactly the `ANSI_SQL` path, so the supported function
   subset is unchanged; the spec's `IFNULL` / `NVL` / `CEILING` aliases stay outside it.
   
   Identifier quoting follows `expression_language.md`: the Ossie dialect's quote
   character is the ANSI double quote, so `SUM("ORDERS"."PROFIT")` compiles to
   `SUM([orders].[profit])`. Bracket notation remains accepted only for `TABLEAU` and, as
   a documented compatibility case, `ANSI_SQL` — behaviour for existing dialects is
   unchanged.
   
   Calculated *fields* are out of scope: `FieldMappingHandler.java:302` drops those for
   every non-`TABLEAU` dialect, which predates this dialect and is a separate gap.
   
   ## Verification
   
   - `mvn -B clean verify` in `converters/salesforce`: 289 tests, 0 failures, 0 errors,
     0 skipped, with the Salesforce schema installed per the README.
   - Same run without the schema, matching CI: green, with only the 15 pre-existing
     schema-gated skips.
   - The three new translator tests and the portable metric added to
     `translatedComposedMetricsValidateAgainstTheSalesforceSchema` fail when the main-code
     change is reverted.
   - End-to-end against a live Tableau Next org: the exported model POSTs `201` and
     `/validate` returns `isValid: true` with no validation errors — both for a
     hand-written model and for one imported back from an existing org model
     (3 data objects, 43 fields, 2 relationships). Test models were deleted afterwards.
   
   ## Related Issues
   
   Part of #442 (the Salesforce converter was not listed among the original affected call
   sites), following the same pattern as #509.
   
   This touches the translator added in #404. #403 stays open for its author's remaining
   milestones; none of them mention this dialect, and its stated scope is `SNOWFLAKE` and
   `ANSI_SQL` translation.
   
   ## Checklist
   
   Sections this change does not touch (Specification, Ontology, Validation, Examples)
   are omitted rather than left unchecked.
   
   ### Converters
   - [x] Converter logic updated; `converters/salesforce/README.md` documents the selection
         order, the quoting rule and the aliases that stay unsupported
   - [x] Tests live under the converter's test directory
   
   ### Tests
   - [x] All existing tests pass: 289 passed, 0 skipped locally; green on the CI profile
   - [x] New functionality is covered by tests, and they fail without the fix
   
   ### Compliance
   - [x] ASF license headers present (no new files added)
   - [x] No third-party dependencies added
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(salesforce): read OSSIE_SQL_2026 metric expressions [ossie]

["jbonofre (via GitHub)" <gi...@apache.org>]

jbonofre merged PR #513:
URL: https://github.com/apache/ossie/pull/513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org