You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/24 07:54:28 UTC
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request
#4075: Encrypt statement IN operator contains space and line break
SteNicholas opened a new pull request #4075: Encrypt statement IN operator contains space and line break
URL: https://github.com/apache/incubator-shardingsphere/pull/4075
Fixes #4037.
Encrypt statement IN operator contains space and line break could extraly append `(`, because method `extractInExpressionSegments` extracts first `ParameterMarkerExpressionSegment` start index not depend on `TerminalNodeImpl` `(`. Therefore, first `ParameterMarkerExpressionSegment` start index should be set with start index of `TerminalNodeImpl` `(`.
Changes proposed in this pull request:
- Method `extractInExpressionSegments` extracts first `ParameterMarkerExpressionSegment` start index with `TerminalNodeImpl` `(`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #4075:
Encrypt statement IN operator contains space and line break
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #4075: Encrypt statement IN operator contains space and line break
URL: https://github.com/apache/incubator-shardingsphere/pull/4075#issuecomment-578410773
@terrymanu
https://docs.google.com/document/d/1HjDjmaaEB-_eQOH6C4Cv6NxsrkAuaNFovr-oTUOvPbQ/edit?usp=sharing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4075:
Encrypt statement IN operator contains space and line break
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4075: Encrypt statement IN operator contains space and line break
URL: https://github.com/apache/incubator-shardingsphere/pull/4075#issuecomment-578415727
For my understanding, the parser module to extract the expr's start index is correct.
The problem is caused by rewrite module need paren's start index.
The better solution should be:
1. Parse start index of IN paren.
2. Fix SQL conjunction logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas closed pull request #4075:
Encrypt statement IN operator contains space and line break
Posted by GitBox <gi...@apache.org>.
SteNicholas closed pull request #4075: Encrypt statement IN operator contains space and line break
URL: https://github.com/apache/incubator-shardingsphere/pull/4075
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services