You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2018/09/24 17:15:52 UTC
[GitHub] brooklyn-server pull request #1000: Config constraints: add more tests
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/1000
Config constraints: add more tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server config-constraints-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/1000.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1000
----
commit d19d2079b1a2b16c6de8c950b67a2daf0b8d3372
Author: Aled Sage <al...@...>
Date: 2018-09-24T17:14:45Z
Config constraints: add more tests
----
---
[GitHub] brooklyn-server issue #1000: Config constraints: add more tests
Posted by kemitix <gi...@git.apache.org>.
Github user kemitix commented on the issue:
https://github.com/apache/brooklyn-server/pull/1000
LGTM
Some of the assertion helper methods look like they might be useful outwith the class where they are defined. Possible candidates for refactoring later.
---
[GitHub] brooklyn-server pull request #1000: Config constraints: add more tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/1000
---
[GitHub] brooklyn-server issue #1000: Config constraints: add more tests
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/1000
Thanks @kemitix @aledsage - merging
---
[GitHub] brooklyn-server issue #1000: Config constraints: add more tests
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1000
retest this please
Jenkins failure was an environment problem I believe:
```
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://github.com/apache/brooklyn-server.git +refs/pull/*:refs/remotes/origin/pr/*" returned status code 128:
```
---