You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/04 14:56:25 UTC
[GitHub] [druid] richardstartin opened a new pull request #9987: Update RoaringBitmap to 0.8.20
richardstartin opened a new pull request #9987:
URL: https://github.com/apache/druid/pull/9987
Fixes #9920. Some improvements were made to the `FastAggregation` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #9987: Update RoaringBitmap to 0.8.20
Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #9987:
URL: https://github.com/apache/druid/pull/9987#issuecomment-650432181
@richardstartin any chance you can update the license.yaml so we can get this merged? It appears the artifacts are in maven now, so the license check is all that is failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #9987: Update RoaringBitmap to 0.9.0
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #9987:
URL: https://github.com/apache/druid/pull/9987#issuecomment-662610869
@richardstartin thanks for updating the PR 🙂 . The latest version is 0.9.1. Is there a reason to use 0.9.0 instead of it?
> The new intersection algorithm is faster and allocates less memory in a benchmark adapted from druid's benchmarks, but it might be worth testing it out on a cluster before accepting the change.
Could you share your benchmark result if possible? It would be nice if you can contribute the benchmark code as well, but I don't think it's necessary. For cluster testing, do you think that the testing result should be a blocker to merge this PR? I see several performance-wise improvements in the commit history. Since the bitmap is used to query each segment in Druid, it seems enough to me to run simple benchmarks to see the performance of bitmap itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #9987: Update RoaringBitmap to 0.9.0
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #9987:
URL: https://github.com/apache/druid/pull/9987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #9987: Update RoaringBitmap to 0.8.20
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #9987:
URL: https://github.com/apache/druid/pull/9987#issuecomment-662165593
Hi @richardstartin, thank you for all your PRs! It seems like your PR was included in roaring bitmap 0.8.20. Can we proceed now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] richardstartin commented on pull request #9987: Update RoaringBitmap to 0.9.0
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #9987:
URL: https://github.com/apache/druid/pull/9987#issuecomment-662350048
@jihoonson sorry, updated now. The new intersection algorithm is faster and allocates less memory in a benchmark adapted from druid's benchmarks, but it might be worth testing it out on a cluster before accepting the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #9987: Update RoaringBitmap to 0.8.20
Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #9987:
URL: https://github.com/apache/druid/pull/9987#issuecomment-650719703
>I was going to go back and implement the new intersection algorithm which motivated this PR for iterator inputs, because this version update wouldn't make any difference otherwise. I will update once I've done that.
sgtm :+1:
> If you want to pick up 0.8.20 anyway, I can just close this and come back when I've done the above.
Might as well wait until your follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] richardstartin commented on pull request #9987: Update RoaringBitmap to 0.8.20
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #9987:
URL: https://github.com/apache/druid/pull/9987#issuecomment-650613688
@clintropolis sorry, I forgot about this. I was going to go back and implement the new intersection algorithm which motivated this PR for iterator inputs, because this version update wouldn't make any difference otherwise. I will update once I've done that. If you want to pick up 0.8.20 anyway, I can just close this and come back when I've done the above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] richardstartin commented on pull request #9987: Update RoaringBitmap to 0.9.0
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #9987:
URL: https://github.com/apache/druid/pull/9987#issuecomment-662634342
@jihoonson the benchmarks are on this [PR](https://github.com/RoaringBitmap/RoaringBitmap/pull/406). They were actually copied verbatim from druid - so feel free to run druid's bitmap intersection benchmarks yourself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org