[GitHub] [incubator-teaclave] qinkunbao commented on a change in pull request #573: [WAMR] check init return values

[GitBox <gi...@apache.org>]

qinkunbao commented on a change in pull request #573:
URL: https://github.com/apache/incubator-teaclave/pull/573#discussion_r748795489



##########
File path: executor/src/wamr.rs
##########
@@ -115,10 +115,10 @@ impl TeaclaveExecutor for WAMicroRuntime {
 
         set_thread_context(Context::new(runtime))?;
 
-        unsafe { wasm_runtime_init() };
+        let ret = unsafe { wasm_runtime_init() };
+        assert!((ret as bool) != false);

Review comment:
       My thoughts exactly. I will submit a new PR in the future to address the problem.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org