You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/30 05:21:53 UTC
[GitHub] [incubator-nuttx-testing] yamt opened a new pull request #23: Add
macOS builds
yamt opened a new pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402789957
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
> i made it to use the same lists where possible.
> remaining differences are:
>
> * sim: this has real diifferences between macos and linux
Ok, let's add to black list?
> * x86, mips: i couldn't find handy toolchain binary for macos
Can we use macOS builtin toolchain? as I remeber correctly, Linux don't need the special version for x86 arch.
Can we use this for mips?
https://github.com/PinguinoIDE/pinguino-compilers/tree/master/macosx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402816698
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
> > Can we use macOS builtin toolchain? as I remeber correctly, Linux don't need the special version for x86 arch.
>
> x86 is an 32-bit elf binary for qemu. macOS toolchain doesn't support ELF or 32-bit.
>
Let's use x86_64-elf-gcc you just install in cibuild.sh?
> > Can we use this for mips?
> > https://github.com/PinguinoIDE/pinguino-compilers/tree/master/macosx
>
> these binary has different names from linux version.
How about we create a symbol link?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401508514
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
Can we reuse the current dat list? To save VM, we can select one arm plus other arch config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401593551
##########
File path: macOS/fill-cache.sh
##########
@@ -0,0 +1,39 @@
+#! /bin/sh
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -x
+set -e
+
+WORKSPACE=$(pwd)
+MAKE=make
+
+mkdir cache
+
+cd ${WORKSPACE}/tools/kconfig-frontends
+./configure \
Review comment:
do you mean install_tools part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401660326
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
Review comment:
Why not if the change can simplify the script? macOS will be pure subset of Linux if we take this approach for genromfs and flock and HOMEBREW_CACHE also don't need anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on issue #23: Add macOS
builds
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#issuecomment-611317092
@xiaoxiang781216 i removed majority of arm lists from macOS list, except arm-13.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401588085
##########
File path: .github/workflows/build.yml
##########
@@ -68,3 +68,64 @@ jobs:
run: |
cd testing
./cibuild.sh -x testlist/${{matrix.boards}}.dat
+
+ build-macos:
Review comment:
will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402807085
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
> Can we use macOS builtin toolchain? as I remeber correctly, Linux don't need the special version for x86 arch.
x86 is an 32-bit elf binary for qemu. macOS toolchain doesn't support ELF or 32-bit.
> Can we use this for mips?
> https://github.com/PinguinoIDE/pinguino-compilers/tree/master/macosx
these binary has different names from linux version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402035939
##########
File path: macOS/fill-cache.sh
##########
@@ -0,0 +1,39 @@
+#! /bin/sh
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402856670
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
is it that important to use the same list?
IMO it's better to have a linux-only list to cover them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401561579
##########
File path: macOS/fill-cache.sh
##########
@@ -0,0 +1,39 @@
+#! /bin/sh
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -x
+set -e
+
+WORKSPACE=$(pwd)
+MAKE=make
+
+mkdir cache
+
+cd ${WORKSPACE}/tools/kconfig-frontends
+./configure \
Review comment:
Why not reuse cibuild.sh? I don't think there is too much difference to block sharing the same script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401637038
##########
File path: macOS/cibuild.sh
##########
@@ -0,0 +1,45 @@
+#! /bin/sh
Review comment:
Remove macoOS/cibuild.sh? don't need anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401650963
##########
File path: macOS/cibuild.sh
##########
@@ -0,0 +1,45 @@
+#! /bin/sh
Review comment:
i'm just keeping it for my reference. i'll remove it once everything started workiing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402035970
##########
File path: macOS/cibuild.sh
##########
@@ -0,0 +1,45 @@
+#! /bin/sh
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401651405
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
+ brew install flock
+ ;;
+ Linux)
+ ;;
+ esac
+}
+
function gen-romfs {
- add_path $prebuilt/genromfs/usr/bin
-
- if [ ! -f "$prebuilt/genromfs/usr/bin/genromfs" ]; then
- if [ ! -d "$tools" ]; then
- git clone https://bitbucket.org/nuttx/tools.git $tools
- fi
- mkdir -p $prebuilt; cd $tools
- tar zxf genromfs-0.5.2.tar.gz -C $prebuilt
- cd $prebuilt/genromfs-0.5.2
- make install PREFIX=$prebuilt/genromfs
- cd $prebuilt
- rm -rf genromfs-0.5.2
- fi
+ case $os in
+ Darwin)
+ brew tap PX4/homebrew-px4
Review comment:
maybe. i will try it later when everything else started working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402965445
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
Review comment:
Let's try our best to reuse the test list, the speration is the last resort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401594571
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
How about we add it to the master block list? And fix it as much as possible at later time. It will simplify the maintain cost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401641157
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
The first selection is fix the build break for macOS, but we have to skip it if it's too hard to fix. Anyway, we can catch this corner case in the nightly build(all.dat).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401596977
##########
File path: macOS/fill-cache.sh
##########
@@ -0,0 +1,39 @@
+#! /bin/sh
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -x
+set -e
+
+WORKSPACE=$(pwd)
+MAKE=make
+
+mkdir cache
+
+cd ${WORKSPACE}/tools/kconfig-frontends
+./configure \
Review comment:
Yes, we can even detect the host dynamically and download the tool for different host if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401631125
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
+ brew install flock
+ ;;
+ Linux)
+ ;;
+ esac
+}
+
function gen-romfs {
- add_path $prebuilt/genromfs/usr/bin
-
- if [ ! -f "$prebuilt/genromfs/usr/bin/genromfs" ]; then
- if [ ! -d "$tools" ]; then
- git clone https://bitbucket.org/nuttx/tools.git $tools
- fi
- mkdir -p $prebuilt; cd $tools
- tar zxf genromfs-0.5.2.tar.gz -C $prebuilt
- cd $prebuilt/genromfs-0.5.2
- make install PREFIX=$prebuilt/genromfs
- cd $prebuilt
- rm -rf genromfs-0.5.2
- fi
+ case $os in
+ Darwin)
+ brew tap PX4/homebrew-px4
Review comment:
Can we reuse the generated one from line 68?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401590467
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
because macos needs a different blacklist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r403869761
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
Review comment:
@xiaoxiang781216 do you still want to avoid homebrew stuff?
the latest version is using homebrew for the following tools. i guess it's easy to install flock from the source. but not for the other two.
* u-boot-tools
* flock
* x86_64-elf-gcc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402036099
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
+ brew install flock
+ ;;
+ Linux)
+ ;;
+ esac
+}
+
function gen-romfs {
- add_path $prebuilt/genromfs/usr/bin
-
- if [ ! -f "$prebuilt/genromfs/usr/bin/genromfs" ]; then
- if [ ! -d "$tools" ]; then
- git clone https://bitbucket.org/nuttx/tools.git $tools
- fi
- mkdir -p $prebuilt; cd $tools
- tar zxf genromfs-0.5.2.tar.gz -C $prebuilt
- cd $prebuilt/genromfs-0.5.2
- make install PREFIX=$prebuilt/genromfs
- cd $prebuilt
- rm -rf genromfs-0.5.2
- fi
+ case $os in
+ Darwin)
+ brew tap PX4/homebrew-px4
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402318963
##########
File path: macOS/fill-cache.sh
##########
@@ -0,0 +1,39 @@
+#! /bin/sh
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -x
+set -e
+
+WORKSPACE=$(pwd)
+MAKE=make
+
+mkdir cache
+
+cd ${WORKSPACE}/tools/kconfig-frontends
+./configure \
Review comment:
i removed macos-specific scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #23:
Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#issuecomment-611314196
LGTM, should we just select one arm list for testing? Now mac build has the same data list as Linux which will double the precheck time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401649572
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
Review comment:
i don't see a point to build it from source where the os provides it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402347388
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
i made it to use the same lists where possible.
remaining differences are:
* sim: this has real diifferences between macos and linux
* x86, mips: i couldn't find handy toolchain binary for macos
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401660326
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
Review comment:
Why not if the change can simplify the script? macOS will be pure subset of Linux if we take this approach for genromfs and flock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401631672
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
do you mean to skip configs for linux just because they are broken for macos?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401680105
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
Review comment:
IMO it's better to test with tools people usually use. building this version of flock from source is not something linux folks do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on issue #23: Add macOS
builds
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#issuecomment-610844613
i feel this is ready. does anyone have any concerns?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401594571
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
How about we add it to the master list? And fix it as much as possible at later time. It will simplify the maintain cost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401558088
##########
File path: .github/workflows/build.yml
##########
@@ -68,3 +68,64 @@ jobs:
run: |
cd testing
./cibuild.sh -x testlist/${{matrix.boards}}.dat
+
+ build-macos:
Review comment:
change line 19 to build-linux?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401637288
##########
File path: macOS/fill-cache.sh
##########
@@ -0,0 +1,39 @@
+#! /bin/sh
Review comment:
Remove macOS/fill-cache.sh? don't need anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #23:
Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401635553
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
Review comment:
How about we always build flock from the source like kconfig-frontend? So we don't need do the different action for Linux/macOS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402036214
##########
File path: .github/workflows/build.yml
##########
@@ -68,3 +68,64 @@ jobs:
run: |
cd testing
./cibuild.sh -x testlist/${{matrix.boards}}.dat
+
+ build-macos:
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402832402
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
> Let's use x86_64-elf-gcc you just install in cibuild.sh?
it doesn't work as it doesn't seem to have libgcc for -m32.
> How about we create a symbol link?
blindly assuming they are compatible? i'm not sure if it makes much sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402837296
##########
File path: macOS/testlist/sim-1.dat
##########
@@ -0,0 +1,39 @@
+/sim
Review comment:
If so, let's remove them from the list, all.dat for nightly build will cover them for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r402980699
##########
File path: cibuild.sh
##########
@@ -37,20 +47,39 @@ function python-tools {
add_path $PYTHONUSERBASE/bin
}
+function flock {
+ case $os in
+ Darwin)
+ brew tap discoteq/discoteq
Review comment:
maybe you replied on a wrong thread? anyway i unified the lists as you requested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] yamt commented on a change in pull
request #23: Add macOS builds
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401651026
##########
File path: macOS/fill-cache.sh
##########
@@ -0,0 +1,39 @@
+#! /bin/sh
Review comment:
i'm just keeping it for my reference. i'll remove it once everything started workiing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services