[GitHub] [tinkerpop] javeme commented on issue #1222: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')

[GitBox <gi...@apache.org>]

javeme commented on issue #1222: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')
URL: https://github.com/apache/tinkerpop/pull/1222#issuecomment-558476632
 
 
   @spmallette Thanks.
   > close yours as a "duplicate" and re-reference this PR to that issue
   
   Done.
   
   > if this capability can be safely targetted at the tp34 branch without breaking changes I think that would be a nice feature to have along our current 3.4.x release line
   
   Yes, it is compatible with 3.4.x.  Let's push to tp34 branch.
   
   >  it needs to go an extra step to ensure that metaproperties also work
   
   Sure I also think it is needed to make these steps wholly consistent. I've tested the metaproperties case, and it's OK with this patch:
   ```java
   gremlin> graph = TinkerFactory.createTheCrew()
   ==>tinkergraph[vertices:6 edges:14]
   gremlin> g = graph.traversal()
   ==>graphtraversalsource[tinkergraph[vertices:6 edges:14], standard]
   gremlin> g.V().properties().hasKey('location').properties().hasKey('startTime')
   ==>p[startTime->1997]
   ==>p[startTime->2001]
   ==>p[startTime->2004]
   ==>p[startTime->2005]
   ==>p[startTime->1990]
   ==>p[startTime->2000]
   ==>p[startTime->2006]
   ==>p[startTime->2004]
   ==>p[startTime->2007]
   ==>p[startTime->2011]
   ==>p[startTime->2014]
   ==>p[startTime->1982]
   ==>p[startTime->2005]
   ==>p[startTime->2009]
   ```
   
   > Could you please clarify what's wrong
   
   The Travis issue is caused by HadoopProperty dedup does not work, the root cause is Property comparison will compare the parent elements(here it's edges), but the same edges with two directions are not equal for StarOutEdge and StarInEdge. For TinkerEdge, the same edges with two directions are equal.
   Is it necessary to unify the behavior of edges comparison? like StarEdge and TinkerEdge. I would also be pleasure to submit a patch if necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services