[GitHub] [incubator-milagro-crypto-c] mcarrickscott commented on pull request #95: WIP: Backport some fixes

["mcarrickscott (via GitHub)" <gi...@apache.org>]

mcarrickscott commented on PR #95:
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/95#issuecomment-1449443126

   Not actually a problem, in there by design. I guess the compiler is
   throwing an error only because you have a compiler flag like
   -fsanitize=undefined.
   
   In multi-precision arithmetic with careful programming it is quite common
   to allow controlled overflow to occur. Even Rust in release mode will not
   throw a runtime error in these circumstances.
   
   Mike
   
   On Tue, Feb 28, 2023 at 3:00 PM Matthias Görgens ***@***.***>
   wrote:
   
   > @giorgiozoppi <https://github.com/giorgiozoppi> Sorry, I don't have
   > enough knowledge of how this library works to fix problems like:
   >
   > /src/target/LINUX_64BIT_BLS381_ASan/src/big_384_58.c:945:36: runtime
   > error: left shift of 266483887285207040 by 57 places cannot be represented
   > in type 'long int'
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-milagro-crypto-c/pull/95#issuecomment-1447978036>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAU3ZDRSJOUVKHHUXPKF7PLWZXLFRANCNFSM6AAAAAATEDLYUI>
   > .
   > You are receiving this because you are subscribed to this thread.Message
   > ID: ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org