You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/24 09:49:00 UTC
[jira] [Updated] (FLINK-26843) Cleanup code around TableConfig/ReadableConfig
[ https://issues.apache.org/jira/browse/FLINK-26843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated FLINK-26843:
-----------------------------------
Labels: pull-request-available (was: )
> Cleanup code around TableConfig/ReadableConfig
> ----------------------------------------------
>
> Key: FLINK-26843
> URL: https://issues.apache.org/jira/browse/FLINK-26843
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
> Reporter: Timo Walther
> Assignee: Marios Trivyzas
> Priority: Major
> Labels: pull-request-available
>
> - Replace usages of TableConfig#getLocalTimeZone() with TableConfigUtils.getLocalTimeZone(tableConfig) to facilitate passing ReadableConfig instead of concrete TableConfig.
> - Cleanup code by using the utilitty methods of ShortcutUtils: unwrapTableConfig and unwrapContext.
> Replace TableConfig with ReadableConfig where possible, to cleanup the usages, and make sure that TableConfig is only used where it's absolutely necessary, because of the extra functionality it provides.
> - Cleanup usages and naming of variables regarding TableConfig and ReadableConfig to make clear what is used/passed as variables and method args.
> - Cleanup some test code by using PlannerMocks instead of creating PlannerContext manually.
> - Cleanup some test code by using JsonSerdeTestUtil#configuredSerdeContext() to avoid creating SerdeContexts manually.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)