[GitHub] Thomasbehan opened a new pull request #131: Fix for Camera Crashing on android [TESTED]

[GitBox <gi...@apache.org>]

Thomasbehan opened a new pull request #131: Fix for Camera Crashing on android [TESTED]
URL: https://github.com/apache/cordova-plugin-media-capture/pull/131
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### Motivation and Context
   
   Not requesting the read permission with the write permission which is causing a crash on some devices.
   
   
   ### Description
   updated the captureImage function for android to support better permissions
   
   solves this issue: https://github.com/apache/cordova-plugin-media-capture/issues/96
   #96 
   
   ### Testing
   Tested on Nokia 2
   Pocophone F1
   OnePlus 6
   and android emulator running pie
   
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org