You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/01/17 12:44:59 UTC
[GitHub] [incubator-eventmesh] xwm1992 opened a new issue #718: [Question] Some questions in grpc feature
xwm1992 opened a new issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Question
Now that eventmesh support transfer message with http/tcp/grpc three ways, have some questions below:
- as we first design we have supported two protocols(cloudevents/eventmesh message)
- for http transfer method, we use the `HttpCommand` carry both protocols messages
- for tcp transfer method, we use the `Package` carry both protocols messages
- for grpc transfer method, we use the `EventMeshMessage`/`BatchMessage` carry both protocols messages
Now, for grpc transfer method, I just see convert the `cloudevents` to `eventmesh message`, like pic below. I just think this is a protocols conversion function, but if we treat this just as a message carrier, please don't name it as `EventMeshMessage` because this is a protocol.
@jinrongluo please take a look, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718#issuecomment-1014994102
Discussed with @xwm1992 offline. We agree to rename EventMeshMessage to SimpleMessage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718#issuecomment-1020913379
@jinrongluo Hi, I have some questions for the grpc structure of sdk module, for the Pub side, there batch\publish\request-reply three modes for publish; for the Sub side, I only find the async subcribe mode, how can I use the request-reply for grpc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling closed issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
vongosling closed issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718#issuecomment-1014726511
Hi @xwm1992 Thanks for your review.
GRPC protocol messaging model is different from TCP and HTTP. We have different message model for different Service/Operations:
- EventMeshMessage
- BatchMessage
- Subscription
- Heartbeat
Detail is in this protobuf file:
https://github.com/apache/incubator-eventmesh/blob/grpc/eventmesh-protocol-plugin/eventmesh-protocol-grpc/src/main/proto/eventmesh-client.proto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo edited a comment on issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
jinrongluo edited a comment on issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718#issuecomment-1015541249
hi @xwm1992 as per your suggestion. I rename the GRPC publish message to SimpleMessage.
Here is the commit - https://github.com/apache/incubator-eventmesh/pull/723/commits/802b010ef6686ef4d891bee1214071f9d6787a1c
https://github.com/apache/incubator-eventmesh/pull/723/commits/f0d1b8a0e3c44a114d7ef1422df09c96afc9594c
The PR is here - https://github.com/apache/incubator-eventmesh/pull/723
Thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling commented on issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718#issuecomment-1034550776
I will close this issue, we could create a new issue to discuss the remaining issues for our new Grpc features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jinrongluo commented on issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
jinrongluo commented on issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718#issuecomment-1015541249
hi @xwm1992 as per your suggestion. I rename the GRPC publish message to SimpleMessage.
Here is the commit - https://github.com/apache/incubator-eventmesh/pull/723/commits/802b010ef6686ef4d891bee1214071f9d6787a1c
The PR is here - https://github.com/apache/incubator-eventmesh/pull/723
Thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] vongosling edited a comment on issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
vongosling edited a comment on issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718#issuecomment-1034550776
I will close this issue, we could create a new issue to discuss the remaining issues for our new Grpc features. Codes still in grpc branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on issue #718: [Question] Some questions in grpc feature
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #718:
URL: https://github.com/apache/incubator-eventmesh/issues/718#issuecomment-1020913379
@jinrongluo Hi, I have some questions for the grpc structure of sdk module, for the Pub side, there batch\publish\request-reply three modes for publish; for the Sub side, I only find the async subcribe mode, how can I use the request-reply for grpc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org