You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2020/12/13 06:33:07 UTC
[isis] branch master updated: ISIS-2473: house keeping (2)
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new c29ee58 ISIS-2473: house keeping (2)
c29ee58 is described below
commit c29ee58110c2921a95282f26e967e49cbf3c2222
Author: Andi Huber <ah...@apache.org>
AuthorDate: Sun Dec 13 07:32:52 2020 +0100
ISIS-2473: house keeping (2)
---
.../apache/isis/viewer/wicket/model/models/BookmarkTreeNode.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/BookmarkTreeNode.java b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/BookmarkTreeNode.java
index 3c7680a..8acd45f 100644
--- a/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/BookmarkTreeNode.java
+++ b/viewers/wicket/model/src/main/java/org/apache/isis/viewer/wicket/model/models/BookmarkTreeNode.java
@@ -27,6 +27,7 @@ import java.util.stream.Stream;
import org.apache.wicket.request.mapper.parameter.PageParameters;
import org.apache.isis.commons.internal.base._NullSafe;
+import org.apache.isis.commons.internal.base._Refs;
import org.apache.isis.commons.internal.collections._Lists;
import org.apache.isis.core.metamodel.adapter.oid.Oid;
import org.apache.isis.core.metamodel.adapter.oid.RootOid;
@@ -190,7 +191,7 @@ public class BookmarkTreeNode implements Serializable {
private boolean addToGraphIfParented(BookmarkableModel candidateBookmarkableModel) {
- final boolean whetherAdded[] = {false}; // simply a fast non-thread-safe value reference
+ val whetherAdded = _Refs.booleanRef(false);
// TODO: this ought to be move into a responsibility of BookmarkableModel, perhaps, rather than downcasting
if(candidateBookmarkableModel instanceof EntityModel) {
@@ -219,11 +220,11 @@ public class BookmarkTreeNode implements Serializable {
.forEach(parentOidStr->{
if(Objects.equals(this.oidNoVerStr, parentOidStr)) {
this.addChild(candidateBookmarkableModel);
- whetherAdded[0] = true;
+ whetherAdded.setValue(true);
}
});
}
- return whetherAdded[0];
+ return whetherAdded.isTrue();
}
public void appendGraphTo(List<BookmarkTreeNode> list) {