You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/07/02 15:55:28 UTC
[native-toolchain-CR] Remove colon from filename
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16139
Change subject: Remove colon from filename
......................................................................
Remove colon from filename
Some OSes don't allow cloning the repo if it has a filename
with a colon on it. See
https://github.com/cloudera/native-toolchain/issues/65
for context.
Change-Id: I731f9b818376fcc57f9e47a2bd1bc26ca0b41dc5
---
R source/thrift/thrift-0.9.0-patches/0006-Revert-Thrift-p5_IMPALA-3159-Add-SAN-Wildcard-SSL-cert-client-support-in-python.patch
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/39/16139/1
--
To view, visit http://gerrit.cloudera.org:8080/16139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I731f9b818376fcc57f9e47a2bd1bc26ca0b41dc5
Gerrit-Change-Number: 16139
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Remove colon from filename
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16139 )
Change subject: Remove colon from filename
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I731f9b818376fcc57f9e47a2bd1bc26ca0b41dc5
Gerrit-Change-Number: 16139
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2020 04:01:43 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Remove colon from filename
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/16139 )
Change subject: Remove colon from filename
......................................................................
Patch Set 1: Code-Review+2
LGTM.
Would there be an easy way to fix the process that emits such a filename? Not to stop this patch, but as a future improvement/safeguard against a reoccurrence.
--
To view, visit http://gerrit.cloudera.org:8080/16139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I731f9b818376fcc57f9e47a2bd1bc26ca0b41dc5
Gerrit-Change-Number: 16139
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jul 2020 19:30:58 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Remove colon from filename
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16139 )
Change subject: Remove colon from filename
......................................................................
Remove colon from filename
Some OSes don't allow cloning the repo if it has a filename
with a colon on it. See
https://github.com/cloudera/native-toolchain/issues/65
for context.
Change-Id: I731f9b818376fcc57f9e47a2bd1bc26ca0b41dc5
Reviewed-on: http://gerrit.cloudera.org:8080/16139
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
R source/thrift/thrift-0.9.0-patches/0006-Revert-Thrift-p5_IMPALA-3159-Add-SAN-Wildcard-SSL-cert-client-support-in-python.patch
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Laszlo Gaal: Looks good to me, approved
Tim Armstrong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I731f9b818376fcc57f9e47a2bd1bc26ca0b41dc5
Gerrit-Change-Number: 16139
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Remove colon from filename
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16139 )
Change subject: Remove colon from filename
......................................................................
Patch Set 2:
I'm not sure - these patches are usually manually generated so not sure what happened here.
--
To view, visit http://gerrit.cloudera.org:8080/16139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I731f9b818376fcc57f9e47a2bd1bc26ca0b41dc5
Gerrit-Change-Number: 16139
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2020 04:02:12 +0000
Gerrit-HasComments: No