You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/03 04:11:18 UTC

[GitHub] [spark] Peng-Lei opened a new pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Peng-Lei opened a new pull request #33618:
URL: https://github.com/apache/spark/pull/33618


   ### What changes were proposed in this pull request?
   Add the Resolver to `checkColumnNotExists` to check name exist in case sensitive.
   
   ### Why are the changes needed?
   At now the resolver is `_ == _` of `findNestedField`  called by `checkColumnNotExists`
   Add `alter.conf.resolver` to it.
   [SPARK-36381](https://issues.apache.org/jira/browse/SPARK-36381)
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Add ut tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33618:
URL: https://github.com/apache/spark/pull/33618


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Peng-Lei commented on pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on pull request #33618:
URL: https://github.com/apache/spark/pull/33618#issuecomment-891507272


   @imback82 @cloud-fan Could you take a look ? I'm not quite sure if this is needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Peng-Lei commented on pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on pull request #33618:
URL: https://github.com/apache/spark/pull/33618#issuecomment-891563360


   > I think it's good to have this check so that it's consistent with `SchemaUtils.checkColumnNameDuplication` behavior.
   
   Thank you very much


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] imback82 commented on a change in pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #33618:
URL: https://github.com/apache/spark/pull/33618#discussion_r681440489



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala
##########
@@ -407,6 +408,65 @@ trait AlterTableTests extends SharedSparkSession {
     }
   }
 
+  test("SPARK-36381: Alter add column exist check in case sensitive") {

Review comment:
       maybe move this to https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/connector/V2CommandsCaseSensitivitySuite.scala?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33618:
URL: https://github.com/apache/spark/pull/33618#issuecomment-892278461


   Merged to master and branch-3.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33618:
URL: https://github.com/apache/spark/pull/33618#discussion_r681525435



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala
##########
@@ -407,6 +408,65 @@ trait AlterTableTests extends SharedSparkSession {
     }
   }
 
+  test("SPARK-36381: Alter add column exist check in case sensitive") {

Review comment:
       +1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Peng-Lei commented on a change in pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on a change in pull request #33618:
URL: https://github.com/apache/spark/pull/33618#discussion_r681543537



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala
##########
@@ -407,6 +408,65 @@ trait AlterTableTests extends SharedSparkSession {
     }
   }
 
+  test("SPARK-36381: Alter add column exist check in case sensitive") {

Review comment:
       Done. Thank you very much @imback82 @cloud-fan  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33618: [SPARK-36381][SQL] Add case sensitive and case insensitive compare for checking column name exist when alter table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33618:
URL: https://github.com/apache/spark/pull/33618#issuecomment-891521779


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org