[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4384: [ARM CPU] Fix infer shape error of depthwise

[GitBox <gi...@apache.org>]

kevinthesun commented on a change in pull request #4384: [ARM CPU] Fix infer shape error of depthwise
URL: https://github.com/apache/incubator-tvm/pull/4384#discussion_r349860144
 
 

 ##########
 File path: python/tvm/relay/op/nn/_nn.py
 ##########
 @@ -163,10 +163,17 @@ def compute_conv2d(attrs, inputs, out_type, target):
 
     def _get_out_depth():
         weight_shape = get_const_tuple(inputs[1].shape)
+        # NHWC layout
         if kernel_layout.startswith("HW"):
             return weight_shape[2] * weight_shape[3]
-        return weight_shape[0] * weight_shape[1]
-
+        # NCHW layout.
+        # in ARM CPU contrib_spatial_pack schedule, we will prepack weight layout
 
 Review comment:
   Can we add a compilation test case to cover this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services