You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/03/21 08:54:54 UTC
[PR] [SPARK-47499][PYTHON][CONNECT][TESTS] Reuse `test_help_command` in Connect [spark]
zhengruifeng opened a new pull request, #45634:
URL: https://github.com/apache/spark/pull/45634
### What changes were proposed in this pull request?
Reuse `test_help_command` in Connect
### Why are the changes needed?
for test coverage
I checked [SPARK-5464](https://issues.apache.org/jira/browse/SPARK-5464) that it seems doesn't have to create this test dataframe from python RDD
### Does this PR introduce _any_ user-facing change?
no, test-only
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47499][PYTHON][CONNECT][TESTS] Reuse `test_help_command` in Connect [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45634:
URL: https://github.com/apache/spark/pull/45634#issuecomment-2014116357
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47499][PYTHON][CONNECT][TESTS] Reuse `test_help_command` in Connect [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #45634:
URL: https://github.com/apache/spark/pull/45634#issuecomment-2014107114
> Let's keep `test_help_command` test coverage by reverting the change on `test_dataframe.py`, @zhengruifeng .
I think that test is not related to the RDD usage, but as you mentioned, let me keep it and add a new one for Spark Connect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47499][PYTHON][CONNECT][TESTS] Enable `test_help_command` test [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45634: [SPARK-47499][PYTHON][CONNECT][TESTS] Enable `test_help_command` test
URL: https://github.com/apache/spark/pull/45634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47499][PYTHON][CONNECT][TESTS] Reuse `test_help_command` in Connect [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #45634:
URL: https://github.com/apache/spark/pull/45634#discussion_r1534365768
##########
python/pyspark/sql/tests/test_dataframe.py:
##########
@@ -136,8 +136,7 @@ def test_duplicated_column_names(self):
def test_help_command(self):
# Regression test for SPARK-5464
- rdd = self.sc.parallelize(['{"foo":"bar"}', '{"foo":"baz"}'])
- df = self.spark.read.json(rdd)
+ df = self.spark.createDataFrame([Row(foo="bar"), Row(foo="baz")])
Review Comment:
We should not replace like this because this is a regression test for SPARK-5464 . Please see the JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47499][PYTHON][CONNECT][TESTS] Enable `test_help_command` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45634:
URL: https://github.com/apache/spark/pull/45634#issuecomment-2014423533
All connect tests passed. Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org