You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Enis Soztutar (Created) (JIRA)" <ji...@apache.org> on 2012/04/10 20:03:14 UTC
[jira] [Created] (HBASE-5760) Unit tests should write only under
/target
Unit tests should write only under /target
------------------------------------------
Key: HBASE-5760
URL: https://issues.apache.org/jira/browse/HBASE-5760
Project: HBase
Issue Type: Improvement
Components: test
Affects Versions: 0.96.0
Reporter: Enis Soztutar
Assignee: Enis Soztutar
Priority: Minor
Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5760) Unit tests should write only under
/target
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250894#comment-13250894 ]
stack commented on HBASE-5760:
------------------------------
It does seem like something Mikhail would have fixed in HBASE-5747. I've not checked.
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5760) Unit tests should write only under
/target
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5760:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Enis.
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5760_v1.patch
>
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5760) Unit tests should write only under
/target
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251040#comment-13251040 ]
jiraposter@reviews.apache.org commented on HBASE-5760:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4692/
-----------------------------------------------------------
(Updated 2012-04-10 20:34:07.296907)
Review request for hbase.
Summary
-------
Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
This addresses bug HBASE-5760.
https://issues.apache.org/jira/browse/HBASE-5760
Diffs
-----
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 3f239e0
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 32f0cc3
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java 60f21c0
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 002d611
src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java a6bcbac
Diff: https://reviews.apache.org/r/4692/diff
Testing
-------
Results :
Failed tests: testKeyUpdate(org.apache.hadoop.hbase.security.token.TestZKSecretWatcher): expected:<AuthenticationKey[ id=2, expiration=9223372036854775807 ]> but was:<AuthenticationKey[ id=1, expiration=1334028188780 ]>
Tests in error:
testDelayedRpcImmediateReturnValue(org.apache.hadoop.hbase.ipc.TestDelayedRpc): Call to /127.0.0.1:65022 failed on socket timeout exception: java.net.SocketTimeoutException: 1000 millis timeout while waiting for channel to be ready for read. ch : java.nio.channels.SocketChannel[connected local=/127.0.0.1:65039 remote=/127.0.0.1:65022]
testTralingGarbageCorruptionFileSkipErrorsPasses(org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit): All datanodes 127.0.0.1:52012 are bad. Aborting...
org.apache.hadoop.hbase.security.access.TestAccessControlFilter: Shutting down
org.apache.hadoop.hbase.security.access.TestAccessController: Shutting down
org.apache.hadoop.hbase.security.access.TestTablePermissions: Shutting down
org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher: Shutting down
org.apache.hadoop.hbase.security.token.TestTokenAuthentication: Shutting down
Tests run: 900, Failures: 1, Errors: 7, Skipped: 9
I think the ZKSecretWatcher is unrelated. After the tests, there is no residual test files lying around.
Thanks,
enis
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5760) Unit tests should write only under
/target
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250892#comment-13250892 ]
stack commented on HBASE-5760:
------------------------------
+1
The /build are because of hdfs IIRC.
The /test one is annoying. I think that from mr.
Thanks Enis.
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5760) Unit tests should write only under
/target
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251076#comment-13251076 ]
Hadoop QA commented on HBASE-5760:
----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522164/HBASE-5760_v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1468//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1468//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1468//console
This message is automatically generated.
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
> Attachments: HBASE-5760_v1.patch
>
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5760) Unit tests should write only under
/target
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251361#comment-13251361 ]
Hudson commented on HBASE-5760:
-------------------------------
Integrated in HBase-TRUNK-security #167 (See [https://builds.apache.org/job/HBase-TRUNK-security/167/])
HBASE-5760 Unit tests should write only under /target (Revision 1312043)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5760_v1.patch
>
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5760) Unit tests should write only under
/target
Posted by "Enis Soztutar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HBASE-5760:
---------------------------------
Attachment: HBASE-5760_v1.patch
Attaching the patch from the review. Thanks Stack for the review. I'll take a look at HBASE-5747 shortly.
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
> Attachments: HBASE-5760_v1.patch
>
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5760) Unit tests should write only under
/target
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251287#comment-13251287 ]
Hudson commented on HBASE-5760:
-------------------------------
Integrated in HBase-TRUNK #2740 (See [https://builds.apache.org/job/HBase-TRUNK/2740/])
HBASE-5760 Unit tests should write only under /target (Revision 1312043)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5760_v1.patch
>
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5760) Unit tests should write only under
/target
Posted by "Enis Soztutar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HBASE-5760:
---------------------------------
Status: Patch Available (was: Open)
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
> Attachments: HBASE-5760_v1.patch
>
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5760) Unit tests should write only under
/target
Posted by "Enis Soztutar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251074#comment-13251074 ]
Enis Soztutar commented on HBASE-5760:
--------------------------------------
The downstream patch in HBASE-5747 seems not much correlated with this patch. The biggest change in this is to fix up the MiniMRCluster to use the proper mapred.local.dir, which should also help HBASE-5747. Other tests are not there at 0.89-fb.
> Unit tests should write only under /target
> ------------------------------------------
>
> Key: HBASE-5760
> URL: https://issues.apache.org/jira/browse/HBASE-5760
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Minor
> Attachments: HBASE-5760_v1.patch
>
>
> Some of the unit test runs result in files under $hbase_home/test, $hbase_home/build, or $hbase_home/. We should ensure that all tests use target as their data location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira