[jira] Commented: (GERONIMO-2354) Replace concurrent with backport-concurrent-util

["Bill Dudney (JIRA)" <de...@geronimo.apache.org>]

    [ http://issues.apache.org/jira/browse/GERONIMO-2354?page=comments#action_12432528 ] 
            
Bill Dudney commented on GERONIMO-2354:
---------------------------------------

I tried out this patch, 2 issues;

1) this patch is painful to apply (let me knowif I did something wrong, or if there is a better way);

bootstrap
apply the openejb patch to target/external/openejb2
apply the geronimo patch
manually delete the two empty files (ClockPool.java, ThreadPool.java)
rebuild modules so openejb can build (cd modules, mvn install)
rebuild openejb (cd target/external/openejb2, mvn install)
rebuild G (cd ../../.., mvn install)
cp the tomcat assembly, unzip & untar

2) The startup fails with the following exception, looks like there is still something mixed up in the dependencies;

Module  1/20 org.apache.geronimo.configs/rmi-naming/1.2-SNAPSHOT/car             Exception in thread "main" java.lang.NoClassDefFoundError: EDU/oswego/cs/dl/util/concurrent/Executor
        at java.lang.ClassLoader.defineClass0(Native Method)
        at java.lang.ClassLoader.defineClass(ClassLoader.java:539)
        at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:123)
        at org.apache.geronimo.kernel.classloader.JarFileClassLoader.access$200(JarFileClassLoader.java:51)
        at org.apache.geronimo.kernel.classloader.JarFileClassLoader$6.run(JarFileClassLoader.java:275)
        at java.security.AccessController.doPrivileged(Native Method)
        at org.apache.geronimo.kernel.classloader.JarFileClassLoader.findClass(JarFileClassLoader.java:227)
        at org.apache.geronimo.kernel.config.MultiParentClassLoader.loadClass(MultiParentClassLoader.java:243)
        ...

> Replace concurrent with backport-concurrent-util
> ------------------------------------------------
>
>                 Key: GERONIMO-2354
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2354
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.2
>            Reporter: Jason Dillon
>         Attachments: GERONIMO-2354-openejb2.diff, GERONIMO-2354-openejb2.diff, GERONIMO-2354.diff, GERONIMO-2354.diff
>
>
> Replace usage of concurrent classes with backport-concurrent-util.  Preparation for using java.util.concurrent in JDK 1.5, and reduce the need for 2 sets of concurrent classes on the boot classloader.
> Sill need to include concurrent, as activeio and openejb still have some dependencies upon it... but this brings us a step closer to not needing both.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira