[GitHub] [shardingsphere] kimmking commented on a change in pull request #7229: #7163

[GitBox <gi...@apache.org>]

kimmking commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r482945676



##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
 
 1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
 1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option

Review comment:
       previous release notes should be reserved.

##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java
##########
@@ -76,7 +76,7 @@ public String doSharding(final Collection<String> availableTargetNames, final Pr
         if (allowRangeQuery) {
             return availableTargetNames;
         }
-        throw new UnsupportedOperationException("Since the property of `allow.range.query.with.inline.sharding` is false, inline sharding algorithm can not tackle with range query.");
+        throw new UnsupportedOperationException("Since the property of `allow-range-query-with-inline-sharding` is false, inline sharding algorithm can not tackle with range query.");

Review comment:
       replace allow-range-query-with-inline-sharding with constant




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org