You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by PramodSSImmaneni <gi...@git.apache.org> on 2016/03/20 19:20:08 UTC

[GitHub] incubator-apex-core pull request: APEXCORE-399 Need better debug i...

GitHub user PramodSSImmaneni opened a pull request:

    https://github.com/apache/incubator-apex-core/pull/278

    APEXCORE-399 Need better debug information in stram web service filter initializer

    @vrozov please see

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PramodSSImmaneni/incubator-apex-core stram-ws-filter-debug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #278
    
----
commit 9eba29de8143efd716aba8d2a4bdb085e298ab5a
Author: Pramod Immaneni <pr...@datatorrent.com>
Date:   2016-03-20T18:11:32Z

    Logging of proxy addresses at different computation stages for better debugging

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: APEXCORE-399 Need better debug i...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-apex-core/pull/278


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: APEXCORE-399 Need better debug i...

Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/278#discussion_r56826832
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/security/StramWSFilterInitializer.java ---
    @@ -59,9 +59,11 @@ public void initFilter(FilterContainer container, Configuration conf)
           for (String rmId : ConfigUtils.getRMHAIds(conf)) {
             proxies.add(getResolvedRMWebAppURLWithoutScheme(conf, rmId));
           }
    +      logger.info("HA proxy addresses {}", proxies);
    --- End diff --
    
    Should it be logged at the debug level?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: APEXCORE-399 Need better debug i...

Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/278#discussion_r56865349
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/security/StramWSFilterInitializer.java ---
    @@ -59,9 +59,11 @@ public void initFilter(FilterContainer container, Configuration conf)
           for (String rmId : ConfigUtils.getRMHAIds(conf)) {
             proxies.add(getResolvedRMWebAppURLWithoutScheme(conf, rmId));
           }
    +      logger.info("HA proxy addresses {}", proxies);
    --- End diff --
    
    It's a one time message. Thought it would be easier to find the problem if the information is available right away.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---