You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Podkowinski (JIRA)" <ji...@apache.org> on 2018/12/11 17:13:00 UTC
[jira] [Comment Edited] (CASSANDRA-14806) CircleCI workflow
improvements and Java 11 support
[ https://issues.apache.org/jira/browse/CASSANDRA-14806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717555#comment-16717555 ]
Stefan Podkowinski edited comment on CASSANDRA-14806 at 12/11/18 5:12 PM:
--------------------------------------------------------------------------
Looks good overall.
* We should use java11-executor for the prerequisite clone & build step. This will catch commits that fail to compile in java11 and will also make sure we're testing the same kind of build that we'd ship on releases. This would work for dtests, but not unit tests, hence the use of the `clean` target, before actually running the unit tests. This would slow down tests for run_parallel_junit_tests, but running j11 dtests with a j8 build isn't ideal either. But please feel to go ahead if you feel test runtime is more important for you here, as we would prioritize java8 and may come up with a different solution for java11 dtests later.
* New distributed unit tests support: Thanks for adding this. I wouldn't move them yet and execute along with regular unit test, unless they won't be able to execute on low resources settings.
* I'd prefer to leave the cql tests in, so we can continue to work on them. Keep them in but just don't run them if you're not interested. See my last comment on CASSANDRA-14298.
was (Author: spodxx@gmail.com):
Looks good overall.
* We should use java11-executor for the prerequisite clone & build step. This will catch commits that fail to compile in java11 and will also make sure we're testing the same kind of build that we'd ship on releases. This would work for dtests, but not unit tests, hence the use of the `clean` target, before actually running the unit tests. This would slow down tests for run_parallel_junit_tests, but running j11 dtests with a j8 build isn't ideal either. But please feel to go ahead if you feel test runtime is more important for you here, as should would prioritize java8 and may come up with a different solution for java11 dtests later.
* New distributed unit tests support: Thanks for adding this. I wouldn't move them yet and execute along with regular unit test, unless they won't be able to execute on low resources settings.
* I'd prefer to leave the cql tests in, so we can continue to work on them. Keep them in but just don't run them if you're not interested. See my last comment on CASSANDRA-14298.
> CircleCI workflow improvements and Java 11 support
> --------------------------------------------------
>
> Key: CASSANDRA-14806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14806
> Project: Cassandra
> Issue Type: Improvement
> Components: Build, Testing
> Reporter: Stefan Podkowinski
> Assignee: Stefan Podkowinski
> Priority: Major
>
> The current CircleCI config could use some cleanup and improvements. First of all, the config has been made more modular by using the new CircleCI 2.1 executors and command elements. Based on CASSANDRA-14713, there's now also a Java 11 executor that will allow running tests under Java 11. The {{build}} step will be done using Java 11 in all cases, so we can catch any regressions for that and also test the Java 11 multi-jar artifact during dtests, that we'd also create during the release process.
> The job workflow has now also been changed to make use of the [manual job approval|https://circleci.com/docs/2.0/workflows/#holding-a-workflow-for-a-manual-approval] feature, which now allows running dtest jobs only on request and not automatically with every commit. The Java8 unit tests still do, but that could also be easily changed if needed. See [example workflow|https://circleci.com/workflow-run/be25579d-3cbb-4258-9e19-b1f571873850] with start_ jobs being triggers needed manual approval for starting the actual jobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org