Re: Review Request: CLOUDSTACK-741: Granular Global Parameters

[ASF Subversion and Git Services <as...@urd.zones.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10548/#review19994
-----------------------------------------------------------


Commit 10b6c1c6c8f8c2ec49145a901fb083e7f362f3a1 in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=10b6c1c ]

CLOUDSTACK-741: Granular Global Parameters Added parameters to cluster level cluster.storage.allocated.capacity.notificationthreshold cluster.storage.capacity.notificationthreshold

CLOUDSTACK-2036
global parameter for Router Template ID functionality added
We use 5 parameters to set the router template name for each hypervisor

Moved cpu.overprovisioning.factor and mem.overprovisioning.factor to be able to update/list using update/list configuration API at cluster level.

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On April 19, 2013, 4:07 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10548/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 4:07 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-741: Granular Global Parameters
> 
> Modified UpdateConfiguration API and ListConfiguration API by adding additional parameter scope and resource id (zone/cluster/pool/account).
> Scope decides the parameter which level we can update the value and id is the corresponding id based on the scope.
> This scope is defined in the config.java file where we are creating groups for each level(zone/cluster/pool/account).
> Currently submitted the patch for the zone level parameter use.external.dns.
> 
> Included unit tests and marvin tests.
> 
> 
> This addresses bug CLOUDSTACK-741.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java aabfd4a 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ffeb586 
>   api/src/org/apache/cloudstack/api/response/ConfigurationResponse.java 95b8af2 
>   api/test/org/apache/cloudstack/api/command/test/ListCfgCmdTest.java PRE-CREATION 
>   api/test/org/apache/cloudstack/api/command/test/UpdateCfgCmdTest.java PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolDetailsDao.java be71670 
>   server/src/com/cloud/configuration/Config.java 2993966 
>   server/src/com/cloud/configuration/ConfigurationManager.java afaf0d6 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fc2db7 
>   server/src/com/cloud/configuration/dao/ConfigurationDao.java c86c024 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ab91059 
>   server/src/com/cloud/server/ConfigurationServer.java f441b1f 
>   server/src/com/cloud/server/ConfigurationServerImpl.java c4da1ab 
>   server/src/com/cloud/server/ManagementServerImpl.java 98f789a 
>   server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java 0d797ed 
>   server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 9443815 
>   test/integration/smoke/test_UpdateCfg.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10548/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id
> - tested the modified parameter to take the updated value at zone level(after updation).
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>